Remove hardcoded directory for some footprints #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I've been playing around with modifying your corne v4 and run into some missing file issues. It seems to be that some of the parts here are using a dynamic path variable (and those work). But some paths are hardcoded to your local machine. See below:
This part works:
kbd/kicad-footprints/kbd.pretty/LED_WS2812B-PLCC4.kicad_mod
Line 28 in 930e7d9
But this doesn't:
kbd/kicad-footprints/kbd.pretty/keyswitch_cherrymx_hotswap_1u.kicad_mod
Line 87 in 930e7d9
See how the broken one has your local path hardcoded?
Even still, many of the footprints still use a different dynamic variable. So I'm not sure if this is the correct fix or whether other parts need changing as well.