Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded directory for some footprints #12

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

jradtilbrook
Copy link
Contributor

Hey I've been playing around with modifying your corne v4 and run into some missing file issues. It seems to be that some of the parts here are using a dynamic path variable (and those work). But some paths are hardcoded to your local machine. See below:

This part works:

(model ${KIPRJMOD}/kbd/kicad-packages3D/kbd.3dshapes/WS2812B.step

But this doesn't:

(model "/Users/foostan/go/src/github.com/foostan/kbd/kicad-packages3D/kbd.3dshapes/kailh_hotswap_socket.step"

See how the broken one has your local path hardcoded?

Even still, many of the footprints still use a different dynamic variable. So I'm not sure if this is the correct fix or whether other parts need changing as well.

@jradtilbrook
Copy link
Contributor Author

I noticed the actions were outdated and had failed to setup python on the last run so I've updated those in an attempt to fix it as well.

@foostan
Copy link
Owner

foostan commented Apr 5, 2024

Thank you for your contributions!

It's tricky for this kind of locally run software to get information about the local environment unintentionally, which was a path. I feel it is an issue.

CI is broken, but I'll merge it.

@foostan foostan merged commit 143c1ef into foostan:main Apr 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants