Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle spurious wakeups in Continuation.yield() #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Flowdalic
Copy link

No description provided.

@forax
Copy link
Owner

forax commented Nov 30, 2022

yes, i wonder if it's better to use a while or a do ... while ?

@Flowdalic
Copy link
Author

Using

while (continuation.state == State.WAITED) continuation.condition.await();

would perform an unnecessary comparison in the first iteration. Not really an issue, especially since this first comparison could be optimized away by the compiler, but I personally prefer the current code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants