Merge pull request #3781 from Crebs/@W-15432327

Fix Deprecations and Warning issues

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Common/SalesforceSDKManager.m

@@ -108,10 +108,6 @@ - (void)viewDidLoad {
     self.view.backgroundColor = [UIColor salesforceSystemBackgroundColor];
 }
 
-- (BOOL)shouldAutorotate {
-    return YES;
-}
-
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations {
    return UIInterfaceOrientationMaskAll;
 }

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Common/UIDevice+SFHardware.m

@@ -436,7 +436,12 @@ - (UIInterfaceOrientation)sfsdk_interfaceOrientation {
     UIDeviceOrientation deviceOrientation = UIDevice.currentDevice.orientation;
     UIInterfaceOrientation orientation = (UIInterfaceOrientation)deviceOrientation;
     if (!UIDeviceOrientationIsValidInterfaceOrientation(deviceOrientation)) {
-        orientation = [SFApplicationHelper sharedApplication].windows.firstObject.windowScene.interfaceOrientation;
+        UIWindowScene *windowScene = (UIWindowScene *)[[[SFApplicationHelper sharedApplication] connectedScenes] anyObject];
+        if ([windowScene isKindOfClass:[UIWindowScene class]]) {
+            orientation = windowScene.interfaceOrientation;
+        } else {
+            orientation = UIInterfaceOrientationUnknown;
+        }
     }
     return orientation;
 }

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Login/SFLoginViewController.m

@@ -288,10 +288,6 @@ - (SFSDKLoginHostListViewController *)createLoginHostListViewController {
     return loginHostListViewController;
 }
 
-- (BOOL)shouldAutorotate {
-    return YES;
-}
-
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations {
     return UIInterfaceOrientationMaskAll;
 }

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/OAuth/SFOAuthCredentials.m

@@ -44,7 +44,7 @@
 static NSString * const kSFOAuthDefaultDomain          = @"login.salesforce.com";
 static NSString * const kSFOAuthClusterImplementationKey = @"SFOAuthClusterImplementation";
 
-NSException * SFOAuthInvalidIdentifierException() {
+NSException * SFOAuthInvalidIdentifierException(void) {
     return [[NSException alloc] initWithName:NSInternalInconsistencyException
                                       reason:@"identifier cannot be nil or empty"
                                     userInfo:nil];

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Storage/KeyValueEncryptedFileStoreInspector.swift

@@ -41,8 +41,8 @@ struct KeyValueEncryptedFileStoreInspector: View {
             VStack(alignment: .leading) {
                 Form {
                     Picker(selection: $selectedIndex, label: Text("Store")) {
-                        ForEach(0 ..< stores.count) {
-                            Text(self.stores[$0])
+                        ForEach(stores.indices, id: \.self) { index in
+                            Text(self.stores[index])
                         }
                     }
                     HStack {

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Test/SFSDKTestRequestListener.m

@@ -115,6 +115,10 @@ - (void)oauthCoordinatorDidCancelBrowserAuthentication:(SFOAuthCoordinator *)coo
     NSAssert(NO, @"Web Server flow not supported in this class.");
 }
 
+- (void)oauthCoordinatorDidBeginNativeAuthentication:(nonnull SFOAuthCoordinator *)coordinator {
+    NSAssert(NO, @"Web Server flow not supported in this class.");
+}
+
 - (void)oauthCoordinatorDidAuthenticate:(SFOAuthCoordinator *)coordinator authInfo:(SFOAuthInfo *)info
 {
     [SFSDKCoreLogger i:[self class] format:@"%@ with authInfo: %@", NSStringFromSelector(_cmd), info];

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/UserAccount/SFUserAccount.m

@@ -341,7 +341,7 @@ + (NSString *)loginStateDescriptionFromLoginState:(SFUserAccountLoginState)login
     }
 }
 
-NSString *SFKeyForGlobalScope() {
+NSString *SFKeyForGlobalScope(void) {
     return  SFKeyForUserIdAndScope(nil,nil,nil,SFUserAccountScopeGlobal);
 }
 

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Views/SFSDKDevInfoViewController.m

@@ -139,10 +139,6 @@ - (void)layoutSubviews
     [self layoutTableView];
 }
 
-- (BOOL)shouldAutorotate {
-    return YES;
-}
-
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations {
     return UIInterfaceOrientationMaskAll;
 }

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Views/SFSDKNavigationController.m

@@ -38,10 +38,6 @@ - (void)viewDidAppear:(BOOL)animated {
     [SFSDKViewController refreshAllViews:self.view];
 }
 
-- (BOOL)shouldAutorotate{
-    return self.topViewController.shouldAutorotate;
-}
-
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations {
     return self.topViewController.supportedInterfaceOrientations;
 }

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Views/SFSDKRootController.m

@@ -71,14 +71,6 @@ -(UIViewController *)childViewControllerForStatusBarHidden {
     return nil;
 }
 
--(BOOL)shouldAutorotate
-{
-    UIViewController *topViewController = [SFSDKRootController topViewController:self];
-    if (topViewController!=nil && topViewController!=self)
-        return [topViewController shouldAutorotate];
-    return NO;
-}
-
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations
 {
     UIViewController *topViewController = [SFSDKRootController topViewController:self];

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SFOAuthTestFlowCoordinatorDelegate.m

@@ -101,4 +101,10 @@ - (void)oauthCoordinatorDidCancelBrowserAuthentication:(SFOAuthCoordinator *)coo
     @throw [NSException exceptionWithName:kASWebAuthenticationSessionNotSupportedReasonFormat reason:reason userInfo:nil];
 }
 
+- (void)oauthCoordinatorDidBeginNativeAuthentication:(nonnull SFOAuthCoordinator *)coordinator {
+    [SFLogger log:[self class] level:SFLogLevelDebug format:@"%@ called.", NSStringFromSelector(_cmd)];
+    NSString *reason = [NSString stringWithFormat:kASWebAuthenticationSessionNotSupportedReasonFormat, NSStringFromSelector(_cmd)];
+    @throw [NSException exceptionWithName:kASWebAuthenticationSessionNotSupportedReasonFormat reason:reason userInfo:nil];
+}
+
 @end

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SFSDKWindowManagerTests.m

@@ -90,7 +90,10 @@ @implementation SFSDKWindowManagerTests
 
 - (void)setUp {
     [super setUp];
-    _origApplicationWindow = [UIApplication sharedApplication].keyWindow;
+    UIWindowScene *windowScene = (UIWindowScene *)[[[UIApplication sharedApplication] connectedScenes] anyObject];
+    if ([windowScene isKindOfClass:[UIWindowScene class]]) {
+        _origApplicationWindow = windowScene.windows.firstObject;
+    }
 }
 
 - (void)tearDown {

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SalesforceOAuthUnitTestsCoordinatorDelegate.m

@@ -50,4 +50,8 @@ - (void)oauthCoordinatorDidCancelBrowserAuthentication:(SFOAuthCoordinator *)coo
     XCTFail(@"ASWebAuthenticationSession auth flow is not supported in unit test framework");
 }
 
+- (void)oauthCoordinatorDidBeginNativeAuthentication:(nonnull SFOAuthCoordinator *)coordinator { 
+    // ASWebAuthenticationSession auth flow is not supported in unit test framework.
+    XCTFail(@"ASWebAuthenticationSession auth flow is not supported in unit test framework");
+}
 @end

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SalesforceRestAPITests.m

@@ -1247,7 +1247,7 @@ - (void) testParsePrimingRecordsResponseFromServer {
     SFNativeRestRequestListener *listener = [self sendSyncRequest:request];
     NSDictionary* response = listener.dataResponse;
     @try {
-        SFSDKPrimingRecordsResponse* parsedResponse = [[SFSDKPrimingRecordsResponse alloc] initWith:response];
+        (void)[[SFSDKPrimingRecordsResponse alloc] initWith:response];
     }
     @catch (NSException *exception) {
         XCTFail(@"Unexpected error %@", exception);

libs/SalesforceSDKCore/SalesforceSDKCoreTests/ScreenLockManagerTests.m

@@ -39,7 +39,7 @@ @interface ScreenLockManagerTests : XCTestCase
 @implementation ScreenLockManagerTests
 
 - (void)setUp {
-    BOOL _ = [SFSDKKeychainHelper removeAll];
+    (void)[SFSDKKeychainHelper removeAll];
 }
 
 - (void)testShouldNotLock {

libs/SmartStore/SmartStore/Classes/SFSmartStoreInspectorViewController.m

@@ -451,10 +451,6 @@ - (void)layoutSubviews
     [self.resultGrid reloadData];
 }
 
-- (BOOL)shouldAutorotate {
-    return YES;
-}
-
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations {
     return UIInterfaceOrientationMaskAll;
 }

native/SampleApps/MobileSyncExplorer/MobileSyncExplorer/Classes/ActionsPopupController.m

@@ -47,11 +47,6 @@ - (id)initWithAppViewController:(ContactListViewController *)appViewController {
 
 #pragma mark - View lifecycle
 
--(BOOL)shouldAutorotate
-{
-    return NO;
-}
-
 - (UIInterfaceOrientationMask)supportedInterfaceOrientations
 {
     return UIInterfaceOrientationMaskAll;