-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions #3769
GitHub Actions #3769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
…inished. Move danger files into their own folder. Add CodeCov. Fix static analysis reporting.
|
||
if modified_file_names.include?(report_file_name) || added_file_names.include?(report_file_name) | ||
issues = report['diagnostics'] | ||
print "File modified in PR: #{file}, has #{issue.count} issues.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to leave the various prints in this file so we can check it is working. It's not super obvious if it breaks because it only reports issues in files modified in the PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3769 +/- ##
==========================================
- Coverage 63.37% 63.26% -0.11%
==========================================
Files 225 225
Lines 21538 21576 +38
==========================================
+ Hits 13649 13651 +2
- Misses 7889 7925 +36
Flags with carried forward coverage won't be shown. Click here to find out more. |
Github Actions implementation with:
GITHUB_TOKEN
instead of a personal access token.macos-latest
image and run our tests with xcode set to^16
and ios set to^18
we should automatically run against the latest available with no code changes until Xcode 17/iOS 19 are released.Example dynamic test matrix:
What's not in this PR:
Adding a dispatch workflow that can be trigged manually from the browser w/ inputs.CodeCov