feat: overload "+" with strings

formancehq · Dec 6, 2024 · 77b673d · 77b673d
1 parent 9bf4d35
commit 77b673d
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 0 deletions.
diff --git a/internal/interpreter/evaluate_expr.go b/internal/interpreter/evaluate_expr.go
@@ -99,6 +99,10 @@ func (st *programState) plusOp(left parser.ValueExpr, right parser.ValueExpr) (V
 		expectMapped(expectNumber, func(bi big.Int) opAdd {
 			return MonetaryInt(bi)
 		}),
+
+		expectMapped(expectString, func(str string) opAdd {
+			return String(str)
+		}),
 	))
 
 	if err != nil {

diff --git a/internal/interpreter/infix.go b/internal/interpreter/infix.go
@@ -12,6 +12,7 @@ type opAdd interface {
 
 var _ opAdd = (*MonetaryInt)(nil)
 var _ opAdd = (*Monetary)(nil)
+var _ opAdd = (*String)(nil)
 
 func (m MonetaryInt) evalAdd(st *programState, other parser.ValueExpr) (Value, InterpreterError) {
 	m1 := big.Int(m)
@@ -24,6 +25,15 @@ func (m MonetaryInt) evalAdd(st *programState, other parser.ValueExpr) (Value, I
 	return MonetaryInt(*sum), nil
 }
 
+func (m String) evalAdd(st *programState, other parser.ValueExpr) (Value, InterpreterError) {
+	m1 := string(m)
+	m2, err := evaluateExprAs(st, other, expectString)
+	if err != nil {
+		return nil, err
+	}
+	return String(string(m1) + *m2), nil
+}
+
 func (m Monetary) evalAdd(st *programState, other parser.ValueExpr) (Value, InterpreterError) {
 	m2, err := evaluateExprAs(st, other, expectMonetary)
 	if err != nil {

diff --git a/internal/interpreter/interpreter_test.go b/internal/interpreter/interpreter_test.go
@@ -3543,3 +3543,20 @@ func TestSubMonetaries(t *testing.T) {
 	}
 	test(t, tc)
 }
+
+func TestPlusStringOverload(t *testing.T) {
+	script := `
+		set_tx_meta("k", "a" + "b")
+	`
+
+	tc := NewTestCase()
+	tc.compile(t, script)
+
+	tc.expected = CaseResult{
+		Postings: []Posting{},
+		TxMetadata: map[string]machine.Value{
+			"k": machine.String("ab"),
+		},
+	}
+	test(t, tc)
+}