Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert images to webp and add scripts to keep doing so #189

Merged
merged 13 commits into from
Oct 15, 2024

Conversation

LukasWallrich
Copy link
Contributor

On reflection, it makes little sense to convert to webp on GitHub - there might be exceptions to handle. Instead, this PR converts all jpg/png files to webp (faster and smaller images), adds a script to do such conversions locally when needed, and adds an action that highlights the potential need to convert to webp on PRs that contain pictures - but leaving it up to the contributor / reviewer whether to bother with that at this moment.

@github-actions github-actions bot added content related Relevant to website content cicd Relevant to GitHub workflows labels Oct 15, 2024
Copy link

⚠️ Image Files/References Detected

Image Files not in ignore list:

  • scripts/webp_conversion/picture_archive/content/about/partnerships/cos.png

Image References not in ignore list:

  • content/about/partnerships/partnerships.md: cos.png

Please consider converting these images to WebP format and updating references accordingly.

Copy link

github-actions bot commented Oct 15, 2024

👍 All image files/references (if any) are in webp format, in line with our policy.

@LukasWallrich LukasWallrich marked this pull request as ready for review October 15, 2024 13:35
@LukasWallrich LukasWallrich requested a review from a team as a code owner October 15, 2024 13:35
@LukasWallrich
Copy link
Contributor Author

@flavioazevedo after you probably received a ridiculous amount of notifications from this, it is now good for review. Converting the images to webp will make the webpage a bit faster and smaller, and meet a grant objective.

Copy link
Contributor

@flavioazevedo flavioazevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot stress how amazing this is @LukasWallrich ! REALLY, this is freaking awesome! WOW! THANK YOU!

@flavioazevedo flavioazevedo merged commit c61488d into master Oct 15, 2024
5 checks passed
@flavioazevedo flavioazevedo deleted the webp_conv_and_checks branch October 15, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Relevant to GitHub workflows content related Relevant to website content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants