Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix can't add when value is REG_BINARY #1361

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

dc3l1ne
Copy link
Contributor

@dc3l1ne dc3l1ne commented Jun 29, 2022

it only can accept bytes object when -vt is REG_BINARY
fix the issue that can't add key when value type is REG_BINARY

fix the issue that can't add key when value type is REG_BINARY
@mubix
Copy link
Contributor

mubix commented Mar 19, 2024

@dc3l1ne thanks! This fixes a pretty important issue with the REG_BINARY type. I think this can be optimized a bit to just import a2b_hex but I am looking forward to this merging.

@mubix
Copy link
Contributor

mubix commented Mar 19, 2024

@Marshall-Hallenbeck / @gabrielg5 any chance of getting this merged soon?

@mubix
Copy link
Contributor

mubix commented Mar 19, 2024

REG_MULTI_SZ also seems to have an issue, it doesn't seem to want to add new lines

@Marshall-Hallenbeck
Copy link
Contributor

@Marshall-Hallenbeck / @gabrielg5 any chance of getting this merged soon?

I would gladly test and merge but I'm not a maintainer here, just a contributor :)

@gabrielg5
Copy link
Collaborator

Hey!

I've been checking this PR a moment, seems good! thanks!!

Just one suggestion, what do you think on filling the value (when REG_BINARY) with zeroes to make it work the same as when editing a binary key through the Registry Editor?? (and also avoid the [-] Odd-length string exception)

Let me know!
thanks

examples/reg.py Outdated Show resolved Hide resolved
@mubix
Copy link
Contributor

mubix commented Mar 20, 2024

@gabrielg5 ya, that's perfect!

@mubix
Copy link
Contributor

mubix commented Mar 20, 2024

I don't want to delay this patch but any ideas on how to fix REG_MULTI_SZ?

@gabrielg5
Copy link
Collaborator

Haven't checked it, but I'd handle it in another issue/PR.
Created #1720

@gabrielg5 gabrielg5 added the waiting for response Further information is needed from people who opened the issue or pull request label Mar 20, 2024
@gabrielg5 gabrielg5 self-assigned this Mar 20, 2024
@mubix
Copy link
Contributor

mubix commented Mar 20, 2024

@dc3l1ne hasn't responded here since 2022. Not sure waiting on a response will work :)

@dc3l1ne
Copy link
Contributor Author

dc3l1ne commented Mar 25, 2024

Hey guys, is there anything else I need to do ?
Cuz this is a 2022 PR and I almost forgot it.

Validate HEX length

Co-authored-by: Gabriel Gonzalez <[email protected]>
@gabrielg5 gabrielg5 merged commit 608f426 into fortra:master Mar 26, 2024
9 checks passed
@gabrielg5
Copy link
Collaborator

was about to apply suggestions and noted you already did it
Awesome, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for response Further information is needed from people who opened the issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants