-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix can't add when value is REG_BINARY #1361
Conversation
fix the issue that can't add key when value type is REG_BINARY
@dc3l1ne thanks! This fixes a pretty important issue with the REG_BINARY type. I think this can be optimized a bit to just import a2b_hex but I am looking forward to this merging. |
@Marshall-Hallenbeck / @gabrielg5 any chance of getting this merged soon? |
REG_MULTI_SZ also seems to have an issue, it doesn't seem to want to add new lines |
I would gladly test and merge but I'm not a maintainer here, just a contributor :) |
Hey! I've been checking this PR a moment, seems good! thanks!! Just one suggestion, what do you think on filling the value (when Let me know! |
@gabrielg5 ya, that's perfect! |
I don't want to delay this patch but any ideas on how to fix REG_MULTI_SZ? |
Haven't checked it, but I'd handle it in another issue/PR. |
@dc3l1ne hasn't responded here since 2022. Not sure waiting on a response will work :) |
Hey guys, is there anything else I need to do ? |
Validate HEX length Co-authored-by: Gabriel Gonzalez <[email protected]>
was about to apply suggestions and noted you already did it |
it only can accept bytes object when -vt is REG_BINARY
fix the issue that can't add key when value type is REG_BINARY