Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start remote registry as unprivileged user in reg.py #1638

Merged
merged 2 commits into from
Nov 3, 2023
Merged

start remote registry as unprivileged user in reg.py #1638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fdddb4
start remote registry as unprivileged user in reg.py
dadevel Oct 27, 2023
56a7484
enable access to HKEY_USERS trough reg.py
dadevel Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions examples/reg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
from impacket.examples.utils import parse_target
from impacket.system_errors import ERROR_NO_MORE_ITEMS
from impacket.structure import hexdump
from impacket.smbconnection import SMBConnection
from impacket.smbconnection import SMBConnection, SessionError
from impacket.dcerpc.v5.dtypes import READ_CONTROL


Expand Down Expand Up @@ -173,7 +173,8 @@ def run(self, remoteName, remoteHost):
self.__remoteOps.enableRegistry()
except Exception as e:
logging.debug(str(e))
logging.warning('Cannot check RemoteRegistry status. Hoping it is started...')
logging.warning('Cannot check RemoteRegistry status. Triggering start trough named pipe...')
self.triggerWinReg()
self.__remoteOps.connectWinReg()

try:
Expand All @@ -200,6 +201,17 @@ def run(self, remoteName, remoteHost):
if self.__remoteOps:
self.__remoteOps.finish()

def triggerWinReg(self):
# original idea from https://twitter.com/splinter_code/status/1715876413474025704
tid = self.__smbConnection.connectTree('IPC$')
try:
self.__smbConnection.openFile(tid, r'\winreg', 0x12019f, creationOption=0x40, fileAttributes=0x80)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue what the hex values do, just copied them over from psexec.py.

except SessionError:
# STATUS_PIPE_NOT_AVAILABLE error is expected
pass
# give remote registry time to start
time.sleep(1)

def save(self, dce, keyName):
hRootKey, subKey = self.__strip_root_key(dce, keyName)
outputFileName = "%s\%s.save" % (self.__options.outputPath, subKey)
Expand Down Expand Up @@ -413,8 +425,10 @@ def __strip_root_key(self, dce, keyName):
raise Exception('Error parsing keyName %s' % keyName)
if rootKey.upper() == 'HKLM':
ans = rrp.hOpenLocalMachine(dce)
elif rootKey.upper() == 'HKU':
elif rootKey.upper() == 'HKCU':
dadevel marked this conversation as resolved.
Show resolved Hide resolved
ans = rrp.hOpenCurrentUser(dce)
elif rootKey.upper() == 'HKU':
ans = rrp.hOpenUsers(dce)
elif rootKey.upper() == 'HKCR':
ans = rrp.hOpenClassesRoot(dce)
else:
Expand Down Expand Up @@ -520,7 +534,7 @@ def __parse_lp_data(valueType, valueData):
query_parser.add_argument('-keyName', action='store', required=True,
help='Specifies the full path of the subkey. The '
'keyName must include a valid root key. Valid root keys for the local computer are: HKLM,'
' HKU, HKCR.')
' HKU, HKCU, HKCR.')
query_parser.add_argument('-v', action='store', metavar="VALUENAME", required=False, help='Specifies the registry '
'value name that is to be queried. If omitted, all value names for keyName are returned. ')
query_parser.add_argument('-ve', action='store_true', default=False, required=False, help='Queries for the default '
Expand All @@ -533,7 +547,7 @@ def __parse_lp_data(valueType, valueData):
add_parser.add_argument('-keyName', action='store', required=True,
help='Specifies the full path of the subkey. The '
'keyName must include a valid root key. Valid root keys for the local computer are: HKLM,'
' HKU, HKCR.')
' HKU, HKCU, HKCR.')
add_parser.add_argument('-v', action='store', metavar="VALUENAME", required=False, help='Specifies the registry '
'value name that is to be set.')
add_parser.add_argument('-vt', action='store', metavar="VALUETYPE", required=False, help='Specifies the registry '
Expand All @@ -548,7 +562,7 @@ def __parse_lp_data(valueType, valueData):
delete_parser.add_argument('-keyName', action='store', required=True,
help='Specifies the full path of the subkey. The '
'keyName must include a valid root key. Valid root keys for the local computer are: HKLM,'
' HKU, HKCR.')
' HKU, HKCU, HKCR.')
delete_parser.add_argument('-v', action='store', metavar="VALUENAME", required=False, help='Specifies the registry '
'value name that is to be deleted.')
delete_parser.add_argument('-va', action='store_true', required=False, help='Delete all values under this key.')
Expand All @@ -564,7 +578,7 @@ def __parse_lp_data(valueType, valueData):
save_parser.add_argument('-keyName', action='store', required=True,
help='Specifies the full path of the subkey. The '
'keyName must include a valid root key. Valid root keys for the local computer are: HKLM,'
' HKU, HKCR.')
' HKU, HKCU, HKCR.')
save_parser.add_argument('-o', dest='outputPath', action='store', metavar='\\\\192.168.0.2\share', required=True, help='Output UNC path the target system must export the registry saves to')

# A special backup command to save HKLM\SAM, HKLM\SYSTEM and HKLM\SECURITY
Expand Down