Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Finalize Polish of base.ink.svg XML Source #2

Open
Scosh opened this issue Nov 19, 2017 · 2 comments
Open

Finalize Polish of base.ink.svg XML Source #2

Scosh opened this issue Nov 19, 2017 · 2 comments

Comments

@Scosh
Copy link
Collaborator

Scosh commented Nov 19, 2017

These are not matters of absolute importance, as the XML Structure has already been cleaned and improved considerably by @fes0j, but looking at the XML today, a few questions popped up for me that are perhaps worth considering.

In the following I have copied the XML source with the respective line numbers — to go along with my points, suggestions and questions and to better illustrate each of them:

1. Meaning of this line

@fes0j Do you know what this is? Is this the document ID? If so, should we change it to into something more telling?

16    id="svg2250"

2. Remove rect and use pagecolor instead to define the background colour

I think we could possibly just use this one line:

26      pagecolor="#ffffff" 

To accomplish what the single, lonely rectangle in our document is currently doing in lotsa lines:

102     <rect                                                                                                                                                                                                                                
103        style="display:inline;opacity:1;fill:#262626;fill-opacity:1;stroke:none"                                                                                                                                                          
104        id="rect2982-4"                                                                                                                                                                                                                   
105        width="512"                                                                                                                                                                                                                       
106        height="512"                                                                                                                                                                                                                      
107        x="0"                                                                                                                                                                                                                             
108        y="0"                                                                                                                                                                                                                             
109        inkscape:export-xdpi="300"                                                                                                                                                                                                        
110        inkscape:export-ydpi="300"                                                                                                                                                                                                        
111        inkscape:label="background" />

And it would be better style, because there would be no issues when changing the size and aspect ratio of the documents internally / within Inkscape.

3. Reason for differing inkscape:label occurrence / order

Is there a reason that the paths in these lines …

112     <path                                                                                                                                                                                                                                
113        id="path6107-4-3"                                                                                                                                                                                                                 
114        d="m 110.93017,371.92545 c 13.09251,7.55896 26.18501,15.11793 39.27752,22.67689 l 5.41571,-9.38029 c 6.81427,-11.80205 11.87314,-24.63805 16.75523,-37.61962 4.88295,12.98319 9.93975,25.82103 16.7547,37.62302 l 5.41528,9.37885 
    c 13.0931,-7.55764 26.18517,-15.11707 39.27729,-22.67639 l -5.41528,-9.37886 c -6.72113,-11.64127 -15.16904,-22.30674 -23.74343,-33.0567 13.59647,2.05063 27.05824,4.03779 40.50026,4.0369 l 10.831,-10e-4 c 0.001,-15.11779 4.5e-4,-30.2
    3557 -1.7e-4,-45.35337 l -10.83002,-2.5e-4 c -13.62844,-7e-5 -27.27595,2.03754 -40.95954,4.2969 8.8018,-10.72249 17.39065,-21.52093 24.20401,-33.32386 l 5.41571,-9.38029 c -13.09251,-7.55896 -26.18501,-15.11792 -39.27751,-22.67688 l 
    -5.41571,9.38028 c -6.81422,11.80257 -11.87223,24.63894 -16.757,37.6234 -4.88384,-12.98093 -9.94458,-25.81584 -16.75912,-37.61853 l -5.41231,-9.384 c -13.0931,7.5577 -26.1852,15.11714 -39.27735,22.67648 l 5.41432,9.38054 c 6.72129,11
    .64242 15.17217,22.3089 23.74871,33.05963 -13.59882,-2.0521 -27.0592,-4.03633 -40.503114,-4.03606 l -10.830942,0.001 c -0.0012,15.11781 -4.18e-4,30.23561 2.59e-4,45.35342 l 10.829967,3.4e-4 c 13.62797,2.7e-4 27.27382,-2.03734 40.9594
    9,-4.30184 -8.80177,10.71867 -17.38805,21.51717 -20.79515,27.41859 z"                                                                                                                                                                    
115        inkscape:connector-curvature="0"                                                                                                                                                                                                  
116        sodipodi:nodetypes="ccccccccccccccccccccccccccccccc"                                                                                                                                                                              
117        inkscape:label="star_left"                                                                                                                                                                                                        
118        style="fill:#14b967;fill-opacity:1;stroke:none" />                                                                                                                                                                                
119     <path                                                                                                                                                                                                                                
120        id="path6099-3-7"                                                                                                                                                                                                                 
121        d="m 278.17199,371.92545 c 13.09251,7.55896 26.18501,15.11793 39.27752,22.67689 l 5.41571,-9.38029 c 6.81427,-11.80205 11.87314,-24.63805 16.75523,-37.61962 4.88295,12.98319 9.93975,25.82103 16.7547,37.62302 l 5.41528,9.37885 
    c 13.0931,-7.55764 26.18517,-15.11707 39.27729,-22.67639 l -5.41528,-9.37886 c -6.72113,-11.64127 -15.16904,-22.30674 -23.74343,-33.0567 13.59647,2.05063 27.05824,4.03779 40.50026,4.0369 l 10.831,-10e-4 c 10e-4,-15.11779 4.5e-4,-30.2
    3557 -1.7e-4,-45.35337 l -10.83002,-2.5e-4 c -13.62844,-7e-5 -27.27595,2.03754 -40.95954,4.2969 8.8018,-10.72249 17.39065,-21.52093 24.20401,-33.32386 l 5.41571,-9.38029 c -13.09251,-7.55896 -26.18501,-15.11792 -39.27751,-22.67688 l 
    -5.41571,9.38028 c -6.81422,11.80257 -11.87223,24.63894 -16.757,37.6234 -4.88384,-12.98093 -9.94458,-25.81584 -16.75912,-37.61853 l -5.41231,-9.384 c -13.0931,7.5577 -26.1852,15.11714 -39.27735,22.67648 l 5.41432,9.38054 c 6.72129,11
    .64242 15.17217,22.3089 23.74871,33.05963 -13.59882,-2.0521 -27.0592,-4.03633 -40.50311,-4.03606 l -10.83095,0.001 c -0.001,15.11781 -4.1e-4,30.23561 2.6e-4,45.35342 l 10.82997,3.4e-4 c 13.62797,2.7e-4 27.27382,-2.03734 40.95949,-4.3
    0184 -8.80177,10.71867 -17.38805,21.51717 -20.79515,27.41859 z"                                                                                                                                                                          
122        inkscape:connector-curvature="0"                                                                                                                                                                                                  
123        sodipodi:nodetypes="ccccccccccccccccccccccccccccccc"                                                                                                                                                                              
124        inkscape:label="star_right"                                                                                                                                                                                                       
125        style="fill:#808080;fill-opacity:1;stroke:none" />

… have the inkscape:label attribute mentioned later (lines 117 and 124), while this following path …

126     <path                                                                                                                                                                                                                                
127        inkscape:label="star_top"                                                                                                                                                                                                         
128        id="path6115-9-1"                                                                                                                                                                                                                 
129        d="m 194.54845,227.08595 c 13.09251,7.55896 26.18501,15.11793 39.27752,22.67689 l 5.41571,-9.38029 c 6.81427,-11.80205 11.87314,-24.63805 16.75523,-37.61962 4.88295,12.98319 9.93975,25.82103 16.7547,37.62302 l 5.41528,9.37885 
    c 13.0931,-7.55764 26.18517,-15.11707 39.27729,-22.67639 l -5.41528,-9.37886 c -6.72113,-11.64127 -15.16904,-22.30674 -23.74343,-33.0567 13.59647,2.05063 27.05824,4.03779 40.50026,4.0369 l 10.831,-0.001 c 10e-4,-15.11779 4.5e-4,-30.2
    3557 -1.7e-4,-45.35337 l -10.83002,-2.5e-4 c -13.62844,-7e-5 -27.27595,2.03754 -40.95954,4.2969 8.8018,-10.72249 17.39065,-21.52093 24.20401,-33.32386 l 5.41571,-9.38029 C 304.35421,97.36892 291.26171,89.80996 278.16921,82.251 l -5.4
    1571,9.38028 c -6.81422,11.80257 -11.87223,24.63894 -16.757,37.6234 -4.88384,-12.98093 -9.94458,-25.81584 -16.75912,-37.61853 l -5.41231,-9.384 c -13.0931,7.5577 -26.1852,15.11714 -39.27735,22.67648 l 5.41432,9.38054 c 6.72129,11.642
    42 15.17217,22.3089 23.74871,33.05963 -13.59882,-2.0521 -27.0592,-4.03633 -40.50311,-4.03606 l -10.83095,0.001 c -0.001,15.11781 -4.1e-4,30.23561 2.6e-4,45.35342 l 10.82997,3.4e-4 c 13.62797,2.7e-4 27.27382,-2.03734 40.95949,-4.30184
     -8.80177,10.71867 -17.38805,21.51717 -20.79515,27.41859 z"                                                                                                                                                                              
130        inkscape:connector-curvature="0"                                                                                                                                                                                                  
131        sodipodi:nodetypes="ccccccccccccccccccccccccccccccc"                                                                                                                                                                              
132        style="fill:#b3b3b3;fill-opacity:1;stroke:none" />

… has it occur significantly earlier? (line 127)

It likely makes absolutely no difference in performance or output or whatnot — but it just looks a bit weird, going through the source. ^^


Obviously it is impractical and ridiculous to observe these details with most any other Inkscape file, however, considering we want to automate the SVG and PNG output of this one, it makes sense for the XML to be as cleanly sorted as we can possibly make it.

@davidmehren
Copy link
Member

it makes sense for the XML to be as cleanly sorted as we can possibly make it.

I don't think so. Nobody will look at the source ever again. Unless there is a practical reason to manually edit the code (ie we can't automate something), I would not touch it.
If we edit our logo in the future, Inkscape will change everything as it likes anyway.

Using time to optimize something that does not seem to be relevant in practise at all is futile.

@Scosh
Copy link
Collaborator Author

Scosh commented Nov 19, 2017

Whether or not this is a trivial matter depends largely on the function / future function of this particular file, and in how far a Python script + Makefile would need to procure information from it.

The current filename is misleading, because while base.ink.svg does serve as a base for creating future assets with, it is also currently dual-purpose in that it has the same content as a file we want to use to generate profile pictures with, for various social media outlets.

Such a file should be clean and would not be tampered with within Inkscape anymore.

While, as you correctly assess, a base logo asset file would and might be tampered with, and therefore should not be locked down arbitrarily.

Refer to the newly created issues #5 and #6.

@Scosh Scosh added the bug label Dec 2, 2017
@Scosh Scosh added this to the Finished base.ink.svg milestone Dec 4, 2017
fes0j added a commit that referenced this issue Feb 16, 2018
As in GH-10 discussed, this might be the easy fix.
The border is defined as 0.02px and has the same color as each star.
There is still a little shadow visable (even in a 4096px png) which is caused by anti-aliasing.

After closing GH-2, this topic should be revisited.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants