Prevent leaving the batch open when there's an error setting the chil…

…d batch (#16)
fossas · Mar 21, 2022 · dc71ea2 · dc71ea2
1 parent cc50bd6
commit dc71ea2
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/batch/commands.go b/batch/commands.go
@@ -150,9 +150,7 @@ func (b *BatchSubsystem) batchCommand(c *server.Connection, s *server.Server, cm
 		childBatch, err := b.batchManager.getBatch(childBatchId)
 		if err != nil {
 			_ = c.Error(cmd, fmt.Errorf("cannot get child batch: %v", err))
-			return
-		}
-		if err := b.batchManager.addChild(batch, childBatch); err != nil {
+		} else if err := b.batchManager.addChild(batch, childBatch); err != nil {
 			_ = c.Error(cmd, fmt.Errorf("cannot add child (%s) to batch (%s): %v", childBatchId, batchId, err))
 		}
 		if opened {