Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zlib. #1468

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Upgrade zlib. #1468

merged 1 commit into from
Sep 11, 2024

Conversation

csasarak
Copy link
Contributor

Overview

upgrade zlib.

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@csasarak csasarak requested a review from a team as a code owner September 10, 2024 22:47
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and safe to me!

Any reason we're seeing the warnings for the use of head in this PR even though we haven't changed that code? I don't think I've seen those before

@csasarak
Copy link
Contributor Author

They're new as of the GHC upgrade. GHC itself added some warnings for usages of those functions (in addition to hlint) with the reasoning that the compiler discouraging usage of partial functions is easier for new users of GHC. I write a little bit about it in #1460. I had trouble configuring it so that the warning would be suppressed entirely short of putting pragmas in every place they're used.

@csasarak csasarak merged commit bdc5d7f into master Sep 11, 2024
19 checks passed
@csasarak csasarak deleted the update-zlib branch September 11, 2024 18:02
@csasarak csasarak mentioned this pull request Sep 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants