Update utoipa #10
Draft
Update utoipa #10
+418
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jssblck
requested review from
a team and
nficca
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
utoipaanddocumentedversions.ToSchema,Deserialize, andSerializeto some types that didn't have it before (but should have).Acceptance criteria
Types are documented correctly.
Testing plan
Relied on automated testing.
Metrics
None
Risks
If the docs are wrong, it can be confusing for users.
References
Blocking https://github.com/fossas/sparkle/pull/170.
Checklist