Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MariaDb/MySQL Support #190

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

AviGawande
Copy link
Contributor

@AviGawande AviGawande commented Aug 30, 2024

This PR closes/references issue #189 .

How has this been tested?

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Remove MariaDB/MySQL support from the project by updating database configuration settings and CI workflows to exclude MariaDB/MySQL dependencies and setup.

Enhancements:

  • Remove support for MariaDB/MySQL from the database configuration settings.

CI:

  • Update CI workflow to exclude MariaDB/MySQL from the testing matrix and remove related setup steps.

Copy link

sourcery-ai bot commented Aug 30, 2024

Reviewer's Guide by Sourcery

This pull request removes support for MariaDB/MySQL databases from the project. The changes primarily affect the database configuration settings and the CI workflow, simplifying the codebase by focusing on SQLite and PostgreSQL as the supported database backends.

File-Level Changes

Change Details Files
Remove MariaDB/MySQL specific database configuration
  • Remove MySQL-specific character set and collation settings
  • Remove conditional logic for MySQL database options
  • Remove MySQL-specific test database configuration
src/pretalx/settings.py
Update CI workflow to remove MySQL/MariaDB testing
  • Remove MySQL from the database matrix in GitHub Actions
  • Remove MariaDB setup step from the workflow
  • Remove installation of MySQL client and dependencies
.github/workflows/tests.yml

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AviGawande - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a detailed explanation for removing MySQL/MariaDB support. What motivated this decision, and how does it align with the project's goals?
  • Address the impact on existing MySQL users. Is there a migration path or guidance for users who need to switch databases?
  • Consider updating the PR description with more context about the change, including any performance or maintenance benefits this removal might bring.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 2 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

doc/administrator/installation.rst Outdated Show resolved Hide resolved
doc/administrator/maintenance.rst Outdated Show resolved Hide resolved
@mariobehling mariobehling merged commit cb04c71 into fossasia:development Sep 5, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants