-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto config video component #470
Auto config video component #470
Conversation
Reviewer's Guide by SourceryThis PR implements automatic video component configuration by adding video-related fields to webhook responses and world creation. The changes enable automatic video plugin setup for talk events and handle attendee permissions for the video project. Sequence diagram for event creation with video componentsequenceDiagram
actor User
participant EventForm
participant WebhookService
participant VideoService
User->>EventForm: Fill event creation form
EventForm->>WebhookService: send_event_webhook with is_video_creation
WebhookService->>VideoService: Configure video plugin if is_video_creation
VideoService-->>WebhookService: Acknowledge configuration
WebhookService-->>EventForm: Webhook response
EventForm-->>User: Event created with video component
Class diagram for updated event webhook and world creationclassDiagram
class EventWebhook {
+String locales
+String user_email
+String action
+Boolean is_video_creation
}
class WorldCreation {
+String title
+String timezone
+String locale
+Map traits
}
EventWebhook : +is_video_creation
WorldCreation : +traits
note for EventWebhook "Added is_video_creation field"
note for WorldCreation "Added traits field for attendee permissions"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @odkhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving the hardcoded 'eventyay-video-event-{}' format string to a configuration constant for better maintainability and flexibility
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR resolved #465.
Summary by Sourcery
Add support for video plugin activation and automate attendee permissions for video projects.
New Features:
Enhancements: