Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-9082: Enhance language dropdown button #9131

Merged
merged 23 commits into from Aug 18, 2023
Merged

Feature-9082: Enhance language dropdown button #9131

merged 23 commits into from Aug 18, 2023

Conversation

nnhathung
Copy link
Contributor

Fixes #9082

Short description of what this resolves:

  • Enhance language dropdown button

Changes proposed in this pull request:

  • Enhance language dropdown button

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-event-frontend ❌ Failed (Inspect) Aug 17, 2023 3:22pm

@cweitat
Copy link
Contributor

cweitat commented Aug 17, 2023

@lthanhhieu able to show screenshot? thanks and also mark as ready for review if its done

@nnhathung nnhathung marked this pull request as ready for review August 17, 2023 14:55
@khangon
Copy link
Contributor

khangon commented Aug 17, 2023

Hi @norbusan , @mariobehling , @cweitat ,
We have completed ticket #9082
Please help me check and verify.
Thanks,

Screenshot from 2023-08-17 22-23-55

@mariobehling mariobehling merged commit a341a19 into fossasia:development Aug 18, 2023
8 checks passed
@mariobehling
Copy link
Member

Tested it but it has some issues

  • Clicking between channels sometimes plays the sound of the previous video
  • Clicking between languages sometimes plays both audio channels

Screenshot from 2023-08-18 09-03-22

Reopening the issue. The previous implementation did not always work perfectly neither, but it never played two audio channels at the same time.

norbusan added a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance language dropdown button
5 participants