Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0 #291

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 28, 2023

Bumps github.com/spf13/cobra from 1.6.1 to 1.7.0.

Release notes

Sourced from github.com/spf13/cobra's releases.

v1.7.0

✨ Features

🐛 Bug fixes

🧪 Testing & CI/CD

🔧 Maintenance

✏️ Documentation


This release contains several long running fixes, improvements to powershell completions, and further optimizations for completions.

Thank you everyone who contributed to this release and all your hard work! Cobra and this community would never be possible without all of you! 🐍

Full changelog: spf13/cobra@v1.6.1...v1.7.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 28, 2023
@vkhoroz
Copy link
Member

vkhoroz commented Sep 28, 2023

@camilamacedo86 this is the kind of software upgrade that needs some basic regression testing.

If you have time and energy, feel free to excersize on it.
If you have more urgent items, I will take this after quite some time.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/spf13/cobra-1.7.0 branch 3 times, most recently from 4a423a7 to e3c433f Compare September 28, 2023 14:13
@camilamacedo86
Copy link
Contributor

HI @vkhoroz,

PLease, leave this one with me when I have some spare time I will look at it.

@camilamacedo86 camilamacedo86 self-assigned this Sep 29, 2023
@camilamacedo86
Copy link
Contributor

@dependabot rebase

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.6.1...v1.7.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/spf13/cobra-1.7.0 branch from e3c433f to d4b95aa Compare October 2, 2023 15:57
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @vkhoroz

I tested a couple of commands manually like login and init weaves and all worked as expected. Also, this one is not a MAJOR bump so I think that is enough to let us move forward if not please let me know.

@vkhoroz
Copy link
Member

vkhoroz commented Oct 2, 2023

Thanks @camilamacedo86

Looks sane: spf13/cobra@v1.6.1...v1.7.0

The only two things that could break are:

  • Auto-completion (lots of changes); not essential for us.
  • Argument parsing: spf13/cobra@6b0bd30 (bug fixes are known to create bugs).
    But, as you tested some basic commands with arguments, it should be fine to go.

@vkhoroz vkhoroz merged commit 9cae610 into main Oct 2, 2023
2 checks passed
@vkhoroz vkhoroz deleted the dependabot/go_modules/github.com/spf13/cobra-1.7.0 branch October 2, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants