Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Disable compression in default transport #393

Merged
merged 1 commit into from
Apr 11, 2024
Merged

client: Disable compression in default transport #393

merged 1 commit into from
Apr 11, 2024

Commits on Apr 9, 2024

  1. client: Disable compression in default transport 

    The default Golang client will advertise to the HTTP server that
it can handle gzip compressed response encoding. This is true,
but it breaks our artifacts.go code for doing download progress.

This is because the default behavior of the transport is to:

 * provide the proper reader to decompress the response
 * update the content-length header to be -1

The -1 breaks our logic. This fix gets us back to how things used
to work before CloudFlare started compressing the responses.

Signed-off-by: Andy Doan <[email protected]>
    @doanac
    doanac committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    98b5c15 View commit details
    Browse the repository at this point in the history