Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coverage): allow ir-minimum for versions < 0.8.5 #9341

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(coverage): allow ir-minimum for versions < 0.8.5 #9341

wants to merge 3 commits into from

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #9322
Needs update of compilers dep to include foundry-rs/compilers#216

Solution

@grandizzy grandizzy changed the title Issue 9322 fix(coverage): allow ir-minimum for versions < 0.8.5 Nov 18, 2024
@grandizzy grandizzy changed the title fix(coverage): allow ir-minimum for versions < 0.8.5 fix(coverage): allow ir-minimum for versions < 0.8.5 Nov 18, 2024
@grandizzy grandizzy added the T-blocked Type: blocked label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes will be requested when the pull request is marked ready for review DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr will be requested when the pull request is marked ready for review klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya will be requested when the pull request is marked ready for review yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks will be requested when the pull request is marked ready for review zerosnacks is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-blocked Type: blocked
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: forge coverage --ir-minimum compilation fails with Error: Unknown key "inliner (solc < 0.8.5)
1 participant
@grandizzy