fix: release process #9728
Merged
fix: release process #9728
+7
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
grandizzy
approved these changes
Jan 21, 2025
|
lgmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes issue in release process introduced in #9683
Solution
envpassingtag_namemore flexible in acceptingnightlytags with possibly trailing infofoundryupto use shorthand-Vwhen listing binaries: chore: bump version offoundryupbook#1392We are currently still experiencing an issue with the Docker image being marked as
-devrather than the tag name. The only side effect of this is that the user does not see the nightly warning message. It will be handled as a follow up to prevent further blocking.Build Profilecurrently showsreleaserather thanmaxperfeven though it is compiled with it, appears this is a known issue - the environment variable PROFILE only containsdevorrelease, not the custom profile name. This too is deemed not to be blocking.