Improve forge configuration acquired from tomls

[kkawula]

Closes #2433

Introduced changes

• Configuration parsing logic was moved to the stage of loading it from the file, instead of the previous version - when performing tests

Checklist

• Linked relevant issue
• Updated relevant documentation
• Added relevant tests
• Performed self-review of the code
• Added changes to CHANGELOG.md

[kkawula]

In the linked issue there is listed Block id (e.g. "Latest") is hardcoded, we need to introduce constants, is this still required?
Now we validate this before running tests and this value is used only in two places.

[cptartur]

Let's add a test to see if it's actually being correctly loaded from file. We can improve the overall flow of loading the configuration later.

[kkawula]

Fortunately, these changes are still covered by older tests, e.g. here ->

starknet-foundry/crates/forge/src/scarb.rs

Lines 282 to 463 in f30acaf

	#[test]
	fn get_forge_config_for_package_fails_on_same_fork_name() {
	let temp = setup_package("simple_package");
	let content = indoc!(
	r#"
	[package]
	name = "simple_package"
	version = "0.1.0"
	[[tool.snforge.fork]]
	name = "SAME_NAME"
	url = "http://some.rpc.url"
	block_id.number = "1"
	[[tool.snforge.fork]]
	name = "SAME_NAME"
	url = "http://some.rpc.url"
	block_id.hash = "1"
	"#
	);
	temp.child("Scarb.toml").write_str(content).unwrap();
	let scarb_metadata = ScarbCommand::metadata()
	.inherit_stderr()
	.current_dir(temp.path())
	.run()
	.unwrap();
	let err = load_package_config::<ForgeConfigFromScarb>(
	&scarb_metadata,
	&scarb_metadata.workspace.members[0],
	)
	.unwrap_err();
	assert!(format!("{err:?}").contains("Some fork names are duplicated"));
	}
	#[test]
	fn get_forge_config_for_package_fails_on_multiple_block_id() {
	let temp = setup_package("simple_package");
	let content = indoc!(
	r#"
	[package]
	name = "simple_package"
	version = "0.1.0"
	[[tool.snforge.fork]]
	name = "SAME_NAME"
	url = "http://some.rpc.url"
	block_id.number = "1"
	block_id.hash = "2"
	"#
	);
	temp.child("Scarb.toml").write_str(content).unwrap();
	let scarb_metadata = ScarbCommand::metadata()
	.inherit_stderr()
	.current_dir(temp.path())
	.run()
	.unwrap();
	let err = load_package_config::<ForgeConfigFromScarb>(
	&scarb_metadata,
	&scarb_metadata.workspace.members[0],
	)
	.unwrap_err();
	assert!(format!("{err:?}").contains("block_id should be set once per fork"));
	}
	#[test]
	fn get_forge_config_for_package_fails_on_wrong_block_id() {
	let temp = setup_package("simple_package");
	let content = indoc!(
	r#"
	[package]
	name = "simple_package"
	version = "0.1.0"
	[[tool.snforge.fork]]
	name = "SAME_NAME"
	url = "http://some.rpc.url"
	block_id.wrong_variant = "1"
	"#
	);
	temp.child("Scarb.toml").write_str(content).unwrap();
	let scarb_metadata = ScarbCommand::metadata()
	.inherit_stderr()
	.current_dir(temp.path())
	.run()
	.unwrap();
	let err = load_package_config::<ForgeConfigFromScarb>(
	&scarb_metadata,
	&scarb_metadata.workspace.members[0],
	)
	.unwrap_err();
	assert!(
	format!("{err:?}").contains("block_id = wrong_variant is not valid. Possible values are = \"number\", \"hash\" and \"tag\"")
	);
	}
	#[test]
	fn get_forge_config_for_package_fails_on_wrong_block_tag() {
	let temp = setup_package("simple_package");
	let content = indoc!(
	r#"
	[package]
	name = "simple_package"
	version = "0.1.0"
	[[tool.snforge.fork]]
	name = "SAME_NAME"
	url = "http://some.rpc.url"
	block_id.tag = "Pending"
	"#
	);
	temp.child("Scarb.toml").write_str(content).unwrap();
	let scarb_metadata = ScarbCommand::metadata()
	.inherit_stderr()
	.current_dir(temp.path())
	.run()
	.unwrap();
	let err = load_package_config::<ForgeConfigFromScarb>(
	&scarb_metadata,
	&scarb_metadata.workspace.members[0],
	)
	.unwrap_err();
	assert!(format!("{err:?}").contains("block_id.tag can only be equal to latest"));
	}
	#[test]
	fn get_forge_config_resolves_env_variables() {
	let temp = setup_package("simple_package");
	let content = indoc!(
	r#"
	[package]
	name = "simple_package"
	version = "0.1.0"
	[[tool.snforge.fork]]
	name = "ENV_URL_FORK"
	url = "$ENV_URL_FORK234980670176"
	block_id.number = "1"
	"#
	);
	temp.child("Scarb.toml").write_str(content).unwrap();
	let scarb_metadata = ScarbCommand::metadata()
	.inherit_stderr()
	.current_dir(temp.path())
	.run()
	.unwrap();
	env::set_var("ENV_URL_FORK234980670176", "http://some.rpc.url_from_env");
	let config = load_package_config::<ForgeConfigFromScarb>(
	&scarb_metadata,
	&scarb_metadata.workspace.members[0],
	)
	.unwrap();
	assert_eq!(
	config,
	ForgeConfigFromScarb {
	exit_first: false,
	fork: vec![ForkTarget::new(
	"ENV_URL_FORK".to_string(),
	"http://some.rpc.url_from_env".to_string(),
	"number".to_string(),
	"1".to_string(),
	)],
	fuzzer_runs: None,
	fuzzer_seed: None,
	max_n_steps: None,
	detailed_resources: false,
	save_trace_data: false,
	build_profile: false,
	coverage: false
	}
	);
	}
	}

[kkawula]

Further changes are addressed in issue #2514