Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated short options #2540

Merged
merged 17 commits into from
Oct 3, 2024
Merged

Fix duplicated short options #2540

merged 17 commits into from
Oct 3, 2024

Conversation

franciszekjob
Copy link
Collaborator

@franciszekjob franciszekjob commented Oct 1, 2024 •
edited
Loading

Closes #2538

Introduced changes

  • Remove short option for --accounts-file flag.
  • Change short option to -d for --contract-address flag.
  • Add step to run one test in debug profile. This is because clap can suppress some errors in the release profile due to removed debug assertions.

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@franciszekjob franciszekjob changed the title Add test commands validation Fix duplicated short options Oct 1, 2024
@franciszekjob franciszekjob marked this pull request as ready for review October 1, 2024 15:23
@cptartur cptartur added this pull request to the merge queue Oct 3, 2024
Merged via the queue into master with commit 4c8b752 Oct 3, 2024
24 checks passed
@cptartur cptartur deleted the franciszekjob/2538-fix branch October 3, 2024 11:05
@franciszekjob franciszekjob restored the franciszekjob/2538-fix branch October 10, 2024 20:17
@franciszekjob franciszekjob deleted the franciszekjob/2538-fix branch October 10, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@ksew1 ksew1 Awaiting requested review from ksew1

@integraledelebesgue integraledelebesgue Awaiting requested review from integraledelebesgue

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sncast CLI panics using debug profile
2 participants
@franciszekjob @cptartur