Skip to content

Commit

Permalink
fix: Fix error codes returned by ocular-test, ocular-lint, etc (#7)
Browse files Browse the repository at this point in the history
* Fix error codes returned by ocular-test, ocular-lint, etc

* Drop node 12 from test matrix
  • Loading branch information
nrabinowitz authored Nov 18, 2022
1 parent 9c6cec3 commit b805cde
Show file tree
Hide file tree
Showing 8 changed files with 29 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12, 14, 16]
node-version: [14, 16]

steps:
- uses: actions/[email protected]
Expand Down
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/bootstrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
const shell = require('shelljs');
const path = require('path');

// Runs the bash script and forward the arguments
shell.exec(`${path.resolve(__dirname, './bootstrap.sh')} ${process.argv.slice(2).join(' ')}`);
// Runs the bash script and forward the arguments, exiting with the same code
shell.exit(
shell.exec(`${path.resolve(__dirname, './bootstrap.sh')} ${process.argv.slice(2).join(' ')}`).code
);
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
const shell = require('shelljs');
const path = require('path');

// Runs the bash script and forward the arguments
shell.exec(`${path.resolve(__dirname, './build.sh')} ${process.argv.slice(2).join(' ')}`);
// Runs the bash script and forward the arguments, exiting with the same code
shell.exit(
shell.exec(`${path.resolve(__dirname, './build.sh')} ${process.argv.slice(2).join(' ')}`).code
);
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/clean.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
const shell = require('shelljs');
const path = require('path');

// Runs the bash script and forward the arguments
shell.exec(`${path.resolve(__dirname, './clean.sh')} ${process.argv.slice(2).join(' ')}`);
// Runs the bash script and forward the arguments, exiting with the same code
shell.exit(
shell.exec(`${path.resolve(__dirname, './clean.sh')} ${process.argv.slice(2).join(' ')}`).code
);
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
const shell = require('shelljs');
const path = require('path');

// Runs the bash script and forward the arguments
shell.exec(`${path.resolve(__dirname, './lint.sh')} ${process.argv.slice(2).join(' ')}`);
// Runs the bash script and forward the arguments, exiting with the same code
shell.exit(
shell.exec(`${path.resolve(__dirname, './lint.sh')} ${process.argv.slice(2).join(' ')}`).code
);
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/metrics.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
const shell = require('shelljs');
const path = require('path');

// Runs the bash script and forward the arguments
shell.exec(`${path.resolve(__dirname, './metrics.sh')} ${process.argv.slice(2).join(' ')}`);
// Runs the bash script and forward the arguments, exiting with the same code
shell.exit(
shell.exec(`${path.resolve(__dirname, './metrics.sh')} ${process.argv.slice(2).join(' ')}`).code
);
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
const shell = require('shelljs');
const path = require('path');

// Runs the bash script and forward the arguments
shell.exec(`${path.resolve(__dirname, './publish.sh')} ${process.argv.slice(2).join(' ')}`);
// Runs the bash script and forward the arguments, exiting with the same code
shell.exit(
shell.exec(`${path.resolve(__dirname, './publish.sh')} ${process.argv.slice(2).join(' ')}`).code
);
6 changes: 4 additions & 2 deletions modules/dev-tools/scripts/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
const shell = require('shelljs');
const path = require('path');

// Runs the bash script and forward the arguments
shell.exec(`${path.resolve(__dirname, './test.sh')} ${process.argv.slice(2).join(' ')}`);
// Runs the bash script and forward the arguments, exiting with the same code
shell.exit(
shell.exec(`${path.resolve(__dirname, './test.sh')} ${process.argv.slice(2).join(' ')}`).code
);

0 comments on commit b805cde

Please sign in to comment.