swift: flush writer buffer when closing a chunk #960
Conversation
| @@ -161,6 +161,9 @@ public final class MCAPWriter { | |||
| } | |||
| } else { | |||
| message.serialize(to: &buffer) | |||
| if buffer.count >= options.chunkSize { | |||
There was a problem hiding this comment.
Deceptively, this is actually for un-chunked writing – I thought I might as well use the chunkSize variable to decide when to flush, since it was there. Another option would be that we expose flush as a public method.
There was a problem hiding this comment.
I have been resistant to exposing a public flush method in the go lib. I think we may in rust. I don't really understand the connection here though. If this feature is about unchunked writing why not just do buffer.count >= 0? caveat: I haven't properly
There was a problem hiding this comment.
read the code... finished writing the sentence...?
There was a problem hiding this comment.
Then it would be flushing after every message - is that desirable? Maybe it's fine?
There was a problem hiding this comment.
To be clear, the other line is necessary to ensure we flush when closing a chunk – this part is additionally adding a flush for non-chunked mode
Public-Facing Changes
Swift: data is now properly sent to the writer each time a chunk is closed.
Description