Allow Unix sockets on Windows #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @snoyberg, any chance you could take a look at this? I've been using it successfully for a while. It allows dropping a bunch of CPP. |
|
I'm not familiar with Unix sockets on Windows, but I'm OK with merging this. Can you bump the minor version and update the changelog? |
thomasjm
force-pushed
the
windows-unix-sockets
branch
from
5c73942 to
46c2630
Compare
|
Done! Once this is released, I'd also like to make a small PR to expose this in |
snoyberg
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has supported Unix sockets since since 2017; see here.
This builds for me on Windows 11. I was also able to get
conduitto build against this, making theData.Conduit.Network.Unixmodule available on Windows. Closes #77.