removed availability_zones from asg (#247)

`azs` attribute is for legacy EC2 ASG, which we do not have plan to support any more. Now with terraform 0.12, it causes inconsistent plan issue. So it has to go.
fpco · Nov 19, 2019 · e1e21fb · e1e21fb
1 parent 6ce0363
commit e1e21fb
Show file tree

Hide file tree

Showing 9 changed files with 0 additions and 13 deletions.
diff --git a/examples/asg-lifecycle-hooks/main.tf b/examples/asg-lifecycle-hooks/main.tf
@@ -147,7 +147,6 @@ resource "aws_sns_topic" "main" {
 module "asg" {
   source             	  = "../../modules/asg"
   name_prefix        	  = var.name_prefix
-  azs                	  = local.azs
   elb_names          	  = [aws_elb.web.name]
   subnet_ids         	  = module.vpc.public_subnet_ids
   min_nodes          	  = 1

diff --git a/examples/load-asg/main.tf b/examples/load-asg/main.tf
@@ -118,7 +118,6 @@ module "ubuntu-xenial-ami" {
 module "web-asg" {
   source        = "../../modules/asg"
   ami           = module.ubuntu-xenial-ami.id
-  azs           = local.azs
   name_prefix   = "${var.name}-${var.web_app_name}"
   elb_names     = [aws_elb.web.name]
   instance_type = var.instance_type

diff --git a/examples/vpc-scenario-2-nat-instance/main.tf b/examples/vpc-scenario-2-nat-instance/main.tf
@@ -233,7 +233,6 @@ resource "aws_elb" "web" {
 module "web" {
   source             = "../../modules/asg"
   ami                = module.ubuntu-xenial-ami.id
-  azs                = slice(data.aws_availability_zones.available.names, 0, 3)
   name_prefix        = var.name
   name_suffix        = "webapp-server"
   elb_names          = [aws_elb.web.name]

diff --git a/examples/vpc-scenario-2-nat-instances-per-az/main.tf b/examples/vpc-scenario-2-nat-instances-per-az/main.tf
@@ -244,7 +244,6 @@ resource "aws_elb" "web" {
 module "web" {
   source             = "../../modules/asg"
   ami                = module.ubuntu-xenial-ami.id
-  azs                = slice(data.aws_availability_zones.available.names, 0, 3)
   name_prefix        = var.name
   name_suffix        = "webapp-server"
   elb_names          = [aws_elb.web.name]

diff --git a/examples/vpc-scenario-2/main.tf b/examples/vpc-scenario-2/main.tf
@@ -166,7 +166,6 @@ resource "aws_elb" "web" {
 module "web" {
   source        = "../../modules/asg"
   ami           = module.ubuntu-xenial-ami.id
-  azs           = local.azs
   name_prefix   = "${var.name}-web"
   elb_names     = [aws_elb.web.name]
   instance_type = "t2.nano"

diff --git a/examples/vpc-scenario-3/main.tf b/examples/vpc-scenario-3/main.tf
@@ -139,7 +139,6 @@ resource "aws_elb" "web" {
 module "web" {
   source        = "../../modules/asg"
   ami           = module.ubuntu-xenial-ami.id
-  azs           = local.azs
   name_prefix   = "${var.name}-web"
   elb_names     = [aws_elb.web.name]
   instance_type = "t2.nano"

diff --git a/modules/asg/main.tf b/modules/asg/main.tf
@@ -24,7 +24,6 @@
  */
 # Auto-Scaling Group
 resource "aws_autoscaling_group" "cluster" {
-  availability_zones        = var.azs
   force_delete              = true
   health_check_grace_period = 300
   health_check_type         = var.health_check_type

diff --git a/modules/asg/variables.tf b/modules/asg/variables.tf
@@ -59,11 +59,6 @@ variable "public_ip" {
   type        = string
 }
 
-variable "azs" {
-  description = "list of availability zones to associate with the ASG"
-  type        = list(string)
-}
-
 variable "subnet_ids" {
   description = "list of subnets to associate with the ASG (by id)"
   type        = list(string)

diff --git a/tests/main.tf b/tests/main.tf
@@ -6,7 +6,6 @@ module "asg" {
   source = "../modules/asg"
 
   ami                = ""
-  azs                = []
   key_name           = ""
   max_nodes          = ""
   min_nodes          = ""