Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Add kms to s3 remote state module #302

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Conversation

mcgirr
Copy link
Contributor

@mcgirr mcgirr commented Feb 29, 2020

Initial attempt to add server side encryption to the s3-remote-state module to support

https://www.terraform.io/docs/providers/aws/r/s3_bucket.html#server_side_encryption_configuration

for https://www.terraform.io/docs/backends/types/s3.html#kms_key_id

Contributes to #310

  • Update the changelog
  • Make sure that modules and files are documented. This can be done inside the module and files.
  • Make sure that new modules directories contain a basic README.md file.
  • Make sure that the module is added to tests/main.tf
  • Make sure that the linting passes on CI.
  • Make sure that there is an up to date example for your code:
    - For new modules this would entail example code for how to use the module or some explanation in the module readme.
    - For new examples please provide a README explaining how to run the example. It's also ideal to provide a basic makefile to use the example as well.
  • Make sure that there is a manual CI trigger that can test the deployment.

@mcgirr mcgirr requested a review from ketzacoatl February 29, 2020 06:00
Copy link
Contributor

@ketzacoatl ketzacoatl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge!

modules/s3-remote-state/main.tf Show resolved Hide resolved
modules/s3-remote-state/main.tf Show resolved Hide resolved
@mcgirr mcgirr changed the title WIP: Add kms to s3 remote state module Add kms to s3 remote state module Mar 7, 2020
@mcgirr mcgirr merged commit b4feb7f into master Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants