-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG elements (like motion.text) now update when given a MotionValue as children, matching HTML element behavior #2841
Open
simonkarman
wants to merge
9
commits into
framer:main
Choose a base branch
from
simonkarman:feature/motion-value-child-svg-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−16
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
76388a9
Update the motion value of a child via its firstChild text node inste…
simonkarman 800bcae
Added changelog entry
simonkarman 19cc796
Improved changelog entry
simonkarman 7d0a0b6
Added a test for motion.text inside an svg
simonkarman a2eec07
Still use textContent where possible
simonkarman ed1bb9e
An example of providing a MotionValue to a component directly. Testin…
simonkarman 33e6056
SVG also supports updating through textContent
simonkarman 7cf844f
Since the implementation in HTMLVisualElement and SVGVisualElement is…
simonkarman 21567c1
Updated tests and changelog entry to reflect latest changes
simonkarman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
import { animate, motion, useMotionValue, useTransform } from "framer-motion" | ||
import { useEffect } from "react" | ||
|
||
/** | ||
* An example of providing a MotionValue to a component directly. Testing both | ||
* a SVG text and HTML h1 element. | ||
*/ | ||
export const App = () => { | ||
const count = useMotionValue(0); | ||
const rounded = useTransform(count, Math.round); | ||
useEffect(() => { | ||
const animation = animate(count, 100, { duration: 10 }); | ||
return animation.stop; | ||
}, []) | ||
|
||
return (<> | ||
<p>SVG</p> | ||
<svg | ||
width="250" | ||
height="250" | ||
viewBox="0 0 250 250" | ||
xmlns="http://www.w3.org/2000/svg" | ||
style={{ border: '1px solid white' }} | ||
> | ||
<motion.text | ||
x={125} | ||
y={125} | ||
fontSize={40} | ||
dominantBaseline="middle" | ||
textAnchor="middle" | ||
fill="currentColor" | ||
> | ||
{rounded} | ||
</motion.text> | ||
</svg> | ||
<p>HTML</p> | ||
<motion.h1>{rounded}</motion.h1> | ||
<motion.p>{rounded}</motion.p> | ||
</>) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might still be worth exploring why a
children
prop is set on the SVG elements.Screenshot from example in Chrome macOS: http://localhost:9990/?example=SVG-Text-MotionValue-Child