Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for everything I've done so far on my fork #53

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

PR for everything I've done so far on my fork #53

wants to merge 64 commits into from

Conversation

soichih
Copy link

@soichih soichih commented Jul 21, 2016

No description provided.

@francopestilli
Copy link
Owner

Hi Soichi. I looked over this changes. We should discuss. I am not convinced that this is the repository we want to change.

@soichih
Copy link
Author

soichih commented Aug 25, 2016

Franco,

Do you mean the changes I made to scripts/life_demo.m? Or the fact that there are now new files specific to SCA? On the fork that I am working with Brent, we've put all the SCA related stuff under /sca directory so that those *.sh scripts will be hidden.

If I can't put SCA scripts here, I will need to host those SCA script elsewhere and pull this repo as a dependency - and somehow needs to maintain compatibility with specific version of life code.. I hope we can keep it together.

In any case, you can reject this pull request - since we are making other changes on our fork - we can discuss weather or not to merge it upstream.

@francopestilli
Copy link
Owner

Hi Sochi.

I guess I am still considering options for merging the SCA changes into the general repository.

We might need to discuss a plan to these changes. But the would be good to do in person.

Franco Pestilli
[email protected] mailto:[email protected]
I have a new Google Phone:
(347) 829-4185

On Aug 25, 2016, at 2:06 PM, Soichi Hayashi [email protected] wrote:

Franco,

Do you mean the changes I made to scripts/life_demo.m? Or the fact that there are now new files specific to SCA? On the fork that I am working with Brent, we've put all the SCA related stuff under /sca directory so that those *.sh scripts will be hidden.

If I can't put SCA scripts here, I will need to host those SCA script elsewhere and pull this repo as a dependency - and somehow needs to maintain compatibility with specific version of life code.. I hope we can keep it together.

In any case, you can reject this pull request - since we are making other changes on our fork - we can discuss weather or not to merge it upstream.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub #53 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ACBYc6n2KIoBBPTIofOEBFZRbP1SZQYZks5qjdm3gaJpZM4JR1tv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants