Updating master #40
Merged
Updating master #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… explanations, and rename GetCountryEmojiFlag to GetCountryFlag for clarity.
…y without discarding them. This affects the following files, marking them as modified in the working directory: - README.md: Main project documentation. - docs/README.md: Additional documentation located in the docs directory. - sample/CountryData.Sample.Console/Program.cs: Console application sample code demonstrating usage. - sample/CountryData.Sample.Web.API/Controllers/CountryController.cs: Web API sample controller for country data. - sample/CountryData.Sample.Web.API/Program.cs: Entry point for the Web API sample application. - src/CountryData.Standard/CountryHelper.cs: Core library code for country data manipulation. - test/CountryData.UnitTests/CountryHelperTests.cs: Unit tests for the CountryHelper class.
Re-added `CountryData.Sample.Web.API` project with a new GUID and updated solution configurations accordingly. Enhanced `README.md` with a logo and details on new methods `GetCurrencyCodesByCountryCode` and `GetCountryByCurrencyCode`. Updated `Program.cs` in `CountryData.Sample.CountryConsoleProject` to call new methods. Added new endpoints in `CountryController.cs` for the new methods. Removed `InvariantGlobalization` from `CountryData.Sample.Web.API.csproj`. Updated `Program.cs` in `CountryData.Sample.Web.API` to add controllers and remove comments. Added `Currency` property to `Country.cs` in `CountryData.Standard`. Enhanced `CountryHelper.cs` with new methods, fixed formatting, and added exception handling. Introduced new unit tests in `CountryHelperTests` to verify currency-related methods. Added `Currency` class in new `CountryData.Standard` namespace.
- Added `GetCountryCode(string countryName)` to `CountryData.Standard` to return ISO 3166-1 alpha-2 codes. - Updated `README.md` with documentation for `GetCountryCode`. - Modified `Program.cs` in `CountryData.Sample.CountryConsoleProject` to call and print the result of `GetCountryCode`. - Added `GetCountryCodeByName` API endpoint in `CountryController` within `CountryData.Sample.Web.API.Controllers`. - Updated `CountryData.Sample.Web.API.csproj` to generate XML docs and suppress warning 1591. - Enhanced Swagger configuration in `Program.cs` to include XML comments. - Made `GetCountryData` method in `CountryHelper` virtual for potential overrides. - Added `CountryExtensions` class in `CountryData.Standard` to manage `CountryHelper` and provide country-related methods. - Implemented unit tests for `CountryExtensions` in `CountryExtensionsTests.cs`. - Minor formatting changes in `Currency.cs` and `Regions.cs` to add missing braces. - Changed `app.Run()` to `await app.RunAsync()` in `Program.cs` for async execution.
- Updated `CountryData.Standard.sln` to include `CountryData.Sample.Blazor` and re-add `CountryData.Sample.Web.API` with a new project type GUID. - Added project reference to `CountryData.Sample.MAUI` in `CountryData.Sample.ConsoleProject.csproj`. - Added `Label` element to `MainPage.xaml` for displaying `CountryName`. - Added logging in `CountryController.cs` to log country flag. - Removed `Currency` property from `Country.cs`. - Corrected emoji flag calculation in `CountryHelper.cs`. - Added `appsettings.Development.json` and `appsettings.json` for logging and host configuration. - Added new Blazor project `CountryData.Sample.Blazor` targeting .NET 8.0 with necessary files (`Program.cs`, `App.razor`, `Routes.razor`, `_Imports.razor`, `MainLayout.razor`, `MainLayout.razor.css`, `NavMenu.razor`, `NavMenu.razor.css`, `Error.razor`, `Home.razor`, `CountryService.cs`). - Updated `bootstrap.min.css` with new CSS rules for font family, link colors, button styles, focus effects, form validation, and error handling. - Added new `favicon.png` file.
In Home.razor, added a private field `countries` to store a collection of countries and updated `OnInitializedAsync` to initialize this field by fetching data from `CountryService`. In CountryData.Sample.ConsoleProject.csproj, removed an unnecessary project reference to simplify dependencies.
- Added installation instructions for `CountryData.Standard` in README.md. - Replaced country info table with a dropdown menu in Home.razor. - Added XML documentation comments to `GrtCountryFlag` method.
|
frankodoom
requested review from
Clifftech123
and removed request for
Clifftech123
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
=========================================
Coverage ? 88.17%
=========================================
Files ? 5
Lines ? 93
Branches ? 8
=========================================
Hits ? 82
Misses ? 9
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Clifftech123
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merging recent development iteration into master