rtfeldman#446 remove unused diffLines function

frankschmitt · Oct 31, 2020 · 732b7e1 · 732b7e1
1 parent 033c5bc
commit 732b7e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 37 deletions.
diff --git a/elm/review/src/ReviewConfig.elm b/elm/review/src/ReviewConfig.elm
@@ -32,10 +32,8 @@ config =
 
     , NoUnused.Exports.rule  
         |> Review.Rule.ignoreErrorsForFiles
-            [ "src/Test/Runner/Node/Vendor/Diff.elm"
-            , "src/Test/Runner/Node.elm"
-            --, "src/Test/Runner/Node/Vendor/Console.elm" 
-            --, "src/Test/Reporter/TestResults.elm" -- isTodo
+            [ "x" --"src/Test/Runner/Node/Vendor/Diff.elm"
+            , "src/Test/Runner/Node.elm" -- run, TestProgram are used externally
             ]
     , NoUnused.Modules.rule
     , NoUnused.CustomTypeConstructorArgs.rule

diff --git a/elm/src/Test/Runner/Node/Vendor/Diff.elm b/elm/src/Test/Runner/Node/Vendor/Diff.elm
@@ -1,6 +1,6 @@
 module Test.Runner.Node.Vendor.Diff exposing
     ( Change(..)
-    , diff, diffLines
+    , diff
     )
 
 {-| Compares two list and returns how they have changed.
@@ -79,38 +79,6 @@ type BugReport
     | UnexpectedPath ( Int, Int ) (List ( Int, Int ))
 
 
-{-| Compares two text.
-
-Giving the following text
-
-    a =
-        """aaa
-    bbb
-    ddd"""
-
-    b =
-        """zzz
-    aaa
-    ccc
-    ddd"""
-
-results in
-
-    [ Added "zzz"
-    , NoChange "aaa"
-    , Removed "bbb"
-    , Added "ccc"
-    , NoChange "ddd"
-    ]
-
-.
-
--}
-diffLines : String -> String -> List (Change String)
-diffLines a b =
-    diff (String.lines a) (String.lines b)
-
-
 {-| Compares general lists.
 
     diff [ 1, 3 ] [ 2, 3 ] == [ Removed 1, Added 2, NoChange 3 ] -- True