Properly check for empty HDF5_VERSION in CMake

The old test apparently invoked some weird CMake legacy behavior. This should make the pinned HDF5 Conda version unnecessary (openPMD#1701) since the version with missing HDF5_VERSION is correctly dealt with.
franzpoeschel · Dec 4, 2024 · f9ae099 · f9ae099
1 parent bb45720
commit f9ae099
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -314,7 +314,7 @@ endif()
 string(CONCAT openPMD_HDF5_STATUS "")
 # version: lower limit
 if(openPMD_HAVE_HDF5)
-    if(HDF5_VERSION STREQUAL "")
+    if("${HDF5_VERSION}" STREQUAL "")
         message(WARNING "HDF5_VERSION is empty. Now assuming it is 1.8.13 or newer.")
     else()
         if(HDF5_VERSION VERSION_LESS 1.8.13)

diff --git a/conda.yml b/conda.yml
@@ -23,7 +23,7 @@ dependencies:
   - dask
   - doxygen
   - git
-  - hdf5=1.14.1=mpi_openmpi_*
+  - hdf5=*=mpi_openmpi_*
   - mamba
   - make
   - mpi4py
-Original file line number
+Diff line change
@@ Expand Up / @@ -23,7 +23,7 @@ dependencies: @@
       - dask
       - doxygen
       - git
-      - hdf5=1.14.1=mpi_openmpi_*
+      - hdf5=*=mpi_openmpi_*
       - mamba
       - make
       - mpi4py
@@ Expand Down @@