feat: search functionality in jobs #1113
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms
|
||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
search-functionality-in-jobs
|
| Run status |
|
| Run duration | 00m 31s |
| Commit |
|
| Committer | Ejaaz Khan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
| View all changes introduced in this branch ↗︎ | |
pateljannat
requested changes
Nov 13, 2024
| @@ -68,5 +92,32 @@ const pageMeta = computed(() => { | |||
| } | |||
| }) | |||
|
|
|||
| const jobsList = computed(() => { | |||
| let JobData = jobs.data | |||
There was a problem hiding this comment.
Change JobData to jobData. Follow Camel Case here
| const jobTypes = computed(() => { | ||
| return [ | ||
| '', | ||
| { label: 'Full Time', value: 'Full Time' }, |
There was a problem hiding this comment.
Make labels translatable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #845
Reason of PR
Screenshot / Video
Screen.Recording.2024-11-10.at.9.17.28.PM.mov