Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite recursion in ...Test.Yesod.getResponse #119

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix infinite recursion in ...Test.Yesod.getResponse #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa9e5c3
Fix infinite recursion in ...Test.Yesod.getResponse
chris-martin Sep 19, 2023
ec13cb2
bump version
chris-martin Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
## [_Unreleased_](https://github.com/freckle/freckle-app/compare/v1.9.5.0...main)
## [_Unreleased_](https://github.com/freckle/freckle-app/compare/v1.9.5.1...main)

## [v1.9.5.1](https://github.com/freckle/freckle-app/compare/v1.9.5.0...v1.9.5.1)

- Fixed mistake in `Freckle.App.Test.Yesod.getResponse` producing nontermination

## [v1.9.5.0](https://github.com/freckle/freckle-app/compare/v1.9.4.0...v1.9.5.0)

Expand Down
2 changes: 1 addition & 1 deletion freckle-app.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ cabal-version: 1.18
-- see: https://github.com/sol/hpack

name: freckle-app
version: 1.9.5.0
version: 1.9.5.1
synopsis: Haskell application toolkit used at Freckle
description: Please see README.md
category: Utils
Expand Down
2 changes: 1 addition & 1 deletion library/Freckle/App/Test/Yesod.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@

-- | Clears the current cookies
testClearCookies :: forall m site. MonadYesodExample site m => m ()
testClearCookies = liftYesodExample $ Yesod.Test.testClearCookies

Check warning on line 151 in library/Freckle/App/Test/Yesod.hs

View workflow job for this annotation

GitHub Actions / lint 

Suggestion in testClearCookies in module Freckle.App.Test.Yesod: Redundant $ ▫︎ Found: "liftYesodExample $ Yesod.Test.testClearCookies" ▫︎ Perhaps: "liftYesodExample Yesod.Test.testClearCookies"

-- | Deletes the cookie of the given name
testDeleteCookie
Expand Down Expand Up @@ -180,7 +180,7 @@

-- | Get the most recently provided response value, if available
getResponse :: forall m site. MonadYesodExample site m => m (Maybe SResponse)
getResponse = liftYesodExample getResponse
getResponse = liftYesodExample Yesod.Test.getResponse

-- | The general interface for performing requests
--
Expand Down
2 changes: 1 addition & 1 deletion package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: freckle-app
version: 1.9.5.0
version: 1.9.5.1
maintainer: Freckle Education
category: Utils
github: freckle/freckle-app
Expand Down
Loading