Ensure Kafka consumers include trace_id in log context #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some functions to OpenTelemetry for working with the current trace-id as converted to Datadog's format and for the purposes of setting the log context. It's then re-used in the Middleware from which it was extracted. This will allow us to do the same thing in other persistent-process runners, such as Kafka consumers, just like we do in APIs through the middleware.
This will ensure consumer logs all contain the current `trace_id`.
pbrisbin
changed the title
z0isch
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centralize adding TraceId to the logging context
34671b2
This commit adds some functions to OpenTelemetry for working with the
current trace-id as converted to Datadog's format and for the purposes
of setting the log context. It's then re-used in the Middleware from
which it was extracted.
This will allow us to do the same thing in other persistent-process
runners, such as Kafka consumers, just like we do in APIs through the
middleware.
Wrap runConsumer in withTraceIdContext
98da8d6
This will ensure consumer logs all contain the current
trace_id.Version bump