Add Freckle.App.Http (setRequestMethod)
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why?**
As far as I know there are currently 2 ways to use a non-`GET` request method:
1. including method in the request string (e.g. `parseRequest_ $ "POST " <> url`)
2. importing lower-level HTTP module and setting the field directly (e.g. `req {
HTTP.method = "POST"}`)
**2** breaks the centralization we're providing with this module by requiring
consumers to import an internal thing.
Also both of these are stringly typed, producing a runtime error if a mistake is
made, exs. forgotten space, or casing:
> Note that the request method must be provided as all capital letters.
^ from `http-conduit`'s docs.
**Note**
We could just re-export `Network.HTTP.Simple (setRequestMethod)`, however, still
has the stringly-typed problem (it takes a `ByteString`). `StdMethod` gives us
nice type-safety and covers all our current (and I'd bet future) use-cases.
pbrisbin
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
We could just re-export Network.HTTP.Simple (setRequestMethod), however, it still has the stringly-typed problem
Haha, I have never once thought or cared about this problem. I just use that method and (I guess) always with canonical values like "GET". We should open a PR to make that setRequestMethod do what we're doing here, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
As far as I know there are currently 2 ways to use a non-
GETrequest method:parseRequest_ $ "POST " <> url)req { HTTP.method = "POST"})2 breaks the centralization we're providing with this module by requiring consumers to import an internal thing.
Also both of these are stringly typed, producing a runtime error if a mistake is made, exs. forgotten space, or casing:
^ from
http-conduit's docs.Note
We could just re-export
Network.HTTP.Simple (setRequestMethod), however, it still has the stringly-typed problem (it takes aByteString).StdMethodgives us nice type-safety and covers all our current (and I'd bet future) use-cases.