Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include otel context when forking #180

Merged
merged 3 commits into from
Jul 19, 2024
Merged

include otel context when forking #180

merged 3 commits into from
Jul 19, 2024

Conversation

chris-martin
Copy link
Contributor

No description provided.

Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but it could be worth testing.

You can see https://github.com/freckle/freckle-app/blob/main/tests/Freckle/App/OpenTelemetry/ContextSpec.hs as an example of a spec that pokes at the OTel stuff.

@chris-martin chris-martin merged commit d1093cc into main Jul 19, 2024
6 checks passed
@chris-martin chris-martin deleted the chris/otel-context branch July 19, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants