Use matrix.include to decide if haddocks need uploading #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, I thought only `freckle-kafka` needed this, but since `freckle-app` is still depending on everything, nothing about it's system needs have changed, so it too needs haddocks manually built (still). Now that we have two packages like this, we can move to an `include`-style, which is much easier to maintain.
Merged
chris-martin
approved these changes
Sep 19, 2024
|
It seems like an extra list to maintain for dubious benefit; I'm not sure it's really a problem to spend a little extra GHA time building the docs since it doesn't block anything else. But I'm okay either way. |
|
Yeah, it seems to take about 30m, which I might not call "a little", and this definitely doesn't scale to larger projects (backend would take well over an hour). But you're right that it doesn't block anything since the release has already happened at that point. So I agree, making it non-conditional is simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I thought only
freckle-kafkaneeded this, but sincefreckle-appis still depending on everything, nothing about itssystem needs have changed, so it too needs haddocks manually built
(still).
Now that we have two packages like this, we can move to an
include-style, which is much easier to maintain.