do not wrap exceptions when rethrowing #207
Open
+74
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-martin
requested review from
tomcarste and
pbrisbin
and removed request for
a team and
tomcarste
pbrisbin
approved these changes
Oct 20, 2024
| @@ -97,25 +102,38 @@ try action = withFrozenCallStack $ Annotated.try action | |||
|
|
|||
| tryJust | |||
| :: forall e b m a | |||
| . (Exception e, MonadCatch m, HasCallStack) | |||
| . (Exception e, MonadCatch m) | |||
| => (e -> Maybe b) | |||
| -> m a | |||
| -- ^ Action to run | |||
| -> m (Either b a) | |||
| tryJust test action = | |||
There was a problem hiding this comment.
Couldn't this have been written in terms of catchJust, so we only have to fix this bug once?
tryJust test action = catchJust test (Right <$> action) $ pure . Left?
Comment on lines
+80
to
+81
| -- action $ \e -> | ||
| -- maybe (UnliftIO.Exception.throwIO e) handler (test e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.