curl: fix openssl double free during pkg_shutdown #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcmcdonald91
force-pushed
the
rcm-curl-ossl-init
branch
from
8c45781
to
67fd82b
Compare
rcmcdonald91
force-pushed
the
rcm-curl-ossl-init
branch
from
67fd82b
to
f61ea3e
Compare
|
Good catch! I think we can get rid of the at exit handler, it does not close anything really important that won't be close by the regular stop procedure if the process. That would avoid patching bundled libcurl. (still you work on fixing libcurl in case of being used with program calling atexit is important. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2191
curl/curl#12153
We should keep this until upstream curl takes this patch.