Automatically log into the client application #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the time we're developing the client, we are not testing the login screen, and just want to quickly log in. With a combination of xdotool and oathtool, we can script typing the correct values and login. It's a bit fragile for two reasons. First, we're just blindly typing, so if some other window takes focus or switch, it'll be typed into that window. Second, we're kicking off a background process that sleeps, launching the window in the foreground, and then the background process will do the typing into the foreground. Adapted from work by @legoktm [1] [1]: freedomofpress/securedrop-client#2237
4 tasks
legoktm
reviewed
Oct 2, 2024
Makefile
Outdated
| @echo 'please install oathtool with "sudo qubes-dom0-update oathtool"' | ||
| @false | ||
| endif | ||
| sdw-updater |
There was a problem hiding this comment.
Maybe qvm-run sd-app securedrop-client so it doesn't accidentally trigger the updater and type into it?
There was a problem hiding this comment.
Good point. How does d75911b sound? I preferred to run the desktop file like the launcher does instead of the client application itself.
Makefile
Outdated
| @@ -7,6 +7,11 @@ CONTAINER := $(if $(shell grep "Thirty Seven" /etc/fedora-release),,./scripts/co | |||
|
|
|||
| HOST=$(shell hostname) | |||
|
|
|||
| # Client autologin variables | |||
| CLIENT_TOTP=$(shell oathtool --totp --base32 JHCOGO7VCER3EJ4L --start-time "$(shell date -d "+5 seconds" +"%Y-%m-%d %H:%M:%S")") | |||
There was a problem hiding this comment.
I would just inline this below instead of putting it at the top
There was a problem hiding this comment.
Thanks. Addressed in 9c97d7d
Starting the launcher could lead to autotyping into launcher application instead of the client login prompt.
|
@legoktm what shall we do regarding this one. Shall we close it, unmerged? |
|
@legoktm from a team meeting my understanding is that this is mergeable, actually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Most of the time we're developing the client, we are not testing the login screen, and just want to quickly log in. With a combination of xdotool and oathtool, we can script typing the correct values and login.
It's a bit fragile for two reasons. First, we're just blindly typing, so if some other window takes focus or switch, it'll be typed into that window. Second, we're kicking off a background process that sleeps, launching the window in the foreground, and then the background process will do the typing into the foreground.
Adapted from work by @legoktm: freedomofpress/securedrop-client#2237
Testing
make run-clientxdotoolandoathtool)make run-clientDeployment
dev-facing - no deployment considerations
Checklist
If you have made changes to the provisioning logic
make test) pass indom0If documentation is required