Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ruff >=0.3.5 #7226

Closed
legoktm opened this issue Aug 29, 2024 · 0 comments · Fixed by #7233
Closed

Upgrade to ruff >=0.3.5 #7226

legoktm opened this issue Aug 29, 2024 · 0 comments · Fixed by #7233
Assignees
@legoktm

Comments

@legoktm
Copy link
Member

legoktm commented Aug 29, 2024

Description

We've fallen behind on ruff releases, it's now up to 0.6.x and we're still on 0.0.x. The main reason I'm filing a ticket for it is because the vscode plugin now requires >=0.3.5 to work.
@legoktm legoktm moved this to Cycle Backlog in SecureDrop dev cycle Aug 29, 2024
@legoktm legoktm self-assigned this Sep 19, 2024
@legoktm legoktm moved this from Cycle Backlog to In Progress in SecureDrop dev cycle Sep 19, 2024
@legoktm legoktm mentioned this issue Sep 19, 2024
Merged
4 tasks
legoktm added a commit that referenced this issue Sep 19, 2024
@legoktm
Upgrade ruff, remove black
e4a8c7a 
Upgrade ruff to the latest version so we can use it for formatting and
native editor integration. While we're at it, introduce the standard
`make fix` target
(<freedomofpress/securedrop-tooling#11>).

Actually fixing new issues will happen in follow-ups to make this change
easier to review.

Fixes #7226.
legoktm added a commit that referenced this issue Sep 19, 2024
@legoktm
Upgrade ruff, remove black
6770d12 
Upgrade ruff to the latest version so we can use it for formatting and
native editor integration. While we're at it, introduce the standard
`make fix` target
(<freedomofpress/securedrop-tooling#11>).

We can remove `--show-source` too now that it's the default.

Actually fixing new issues will happen in follow-ups to make this change
easier to review.

Fixes #7226.
@cfm cfm closed this as completed in #7233 Oct 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in SecureDrop dev cycle Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legoktm legoktm

Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade ruff, remove black freedomofpress/securedrop
1 participant
@legoktm