Upgrade ruff, remove black #7233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems busted right now, so I'll retrigger the jobs tomorrow. |
Upgrade ruff to the latest version so we can use it for formatting and native editor integration. While we're at it, introduce the standard `make fix` target (<freedomofpress/securedrop-tooling#11>). We can remove `--show-source` too now that it's the default. Actually fixing new issues will happen in follow-ups to make this change easier to review. Fixes #7226.
This is all automated except test_manage.py was manually fixed to remove extraneous commas that ruff tried to turn into tuples.
About half of these fixes were automatic, the rest I did by hand. I skipped removing % formatting from pretty_bad_protocol since there were like a hundred of them and it wasn't really worth it.
cfm
approved these changes
Oct 7, 2024
6 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This is split into three commits for ease of review:
Upgrade ruff, remove black
Upgrade ruff to the latest version so we can use it for formatting and
native editor integration. While we're at it, introduce the standard
make fixtarget(freedomofpress/securedrop-tooling#11).
Actually fixing new issues will happen in follow-ups to make this change
easier to review.
Fixes #7226.
Apply
ruff format .This is all automated except test_manage.py was manually fixed to remove
extraneous commas that ruff tried to turn into tuples.
Fix most errors spotted by ruff
About half of these fixes were automatic, the rest I did by hand.
I skipped removing % formatting from pretty_bad_protocol since there
were like a hundred of them and it wasn't really worth it.
Testing
How should the reviewer test this PR?
Deployment
Any special considerations for deployment? n/a
Checklist
make lint) and tests (make test) pass in the development containermake -C admin test) pass in the admin development container