Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opinions.css):Front end tweaks #4817

Merged
merged 5 commits into from
Dec 13, 2024
Merged

fix(opinions.css):Front end tweaks #4817

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a0d71e7
fix(opinions.css):Front end tweaks
flooie Dec 12, 2024
2e7338f
Merge branch 'main' into front-end-fixes
flooie Dec 12, 2024
36fe0fc
refactor(opinion.css): Remove font styling
flooie Dec 12, 2024
5345baa
refactor(opinion.html): Add message for PDFs
flooie Dec 13, 2024
229dfe4
fix(opinion.html): Fix typo in opinions.html
flooie Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions cl/assets/static-global/css/opinions.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
.opinion-body {

.harvard > * {
font-family: Merriweather, "Times New Roman", Times, serif;
font-family: "Source Sans Pro", Arial, Helvetica, sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this? Can't you just use the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory no. but I personally find the default font to be off putting .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course I am happy to do what you suggest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the time to discuss or think about fonts. Please remove.

font-size: 15px;
letter-spacing: 0.2px;
text-align: justify;
Expand Down Expand Up @@ -379,24 +379,19 @@ div.footnote:first-of-type {

/*Case Caption CSS*/
#caption-square {
background-color: #F6F2EE;
background-color: whitesmoke;
margin-left: -15px;
margin-right: -15px;
margin-top: -20px;
}

#caption-square > ul > li {
background-color: #fcfaf9;
background-color: #e7e7e7;
border-top-right-radius: 5px 5px; /* Rounds the corners */
border-top-left-radius: 5px 5px; /* Rounds the corners */
margin-left: 4px;
}

#caption-square > ul > li.active {
background-color: #ffffff;
border-bottom: 1px solid lightgrey;
}

#caption-square > ul > li.active {
background-color: #ffffff;
border-bottom: 1px solid white;
Expand All @@ -407,7 +402,6 @@ div.footnote:first-of-type {
}

/*Opinion Date File*/

.case-date-new {
border: 1px solid #B53C2C;
padding: 0px 10px;
Expand Down Expand Up @@ -439,7 +433,7 @@ div.footnote:first-of-type {

#opinion-caption {
margin-top: 20px;
font-family: Merriweather, "Times New Roman", Times, serif;
font-family: "Source Sans Pro", Arial, Helvetica, sans-serif;
font-size: 15px;
letter-spacing: 0.2px;
line-height: 2.3em;
Expand Down Expand Up @@ -530,15 +524,15 @@ div.footnote:first-of-type {
}

div.subopinion-content > .harvard {
font-family: Merriweather, "Times New Roman", Times, serif;
font-family: "Open Sans", Arial, Helvetica, sans-serif;
font-size: 15px;
letter-spacing: 0.2px;
line-height: 2.3em;
text-align: justify;
}

#columbia-text {
font-family: Merriweather, "Times New Roman", Times, serif;
font-family: "Open Sans", Arial, Helvetica, sans-serif;
font-size: 15px;
letter-spacing: 0.2px;
line-height: 2.3em;
Expand Down Expand Up @@ -684,14 +678,14 @@ div.footnote:first-of-type {
}

.case-details {
font-family: Merriweather, "Times New Roman", Times, serif;
font-family: "Source Sans Pro", Arial, Helvetica, sans-serif;
letter-spacing: 0.2px;
line-height:2.3em;
}

.opinion-section-title {
margin-top: 50px;
font-family: Merriweather, "Times New Roman", Times, serif;
font-family: "Source Sans Pro", Arial, Helvetica, sans-serif;
}

/*Add style to align roman numerals */
Expand Down
5 changes: 3 additions & 2 deletions cl/opinion_page/templates/opinions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ <h3><span>Admin</span></h3>
</p>
</div>
{% endif %}

<div id="opinion-toc" class="sidebar-section">
{% if tab == "opinion" %}
<div id="opinion-toc" class="sidebar-section">
<h3> <span>Jump To</span> </h3>
<li class="jump-links active"><a id="nav_top" href="{% if tab != "opinions" %}{% url 'view_case' cluster.pk cluster.slug %}{% endif %}#" class="active">Top</a></li>
<li class="jump-links"><a id="nav_caption" href="{% if tab != "opinions" %}{% url 'view_case' cluster.pk cluster.slug %}{% endif %}#caption" >Caption</a></li>
Expand Down Expand Up @@ -115,6 +115,7 @@ <h3> <span>Jump To</span> </h3>
</li>
{% endfor %}
</div>
{% endif %}

{% if cluster.sub_opinions.all.first.extracted_by_ocr or "U" in cluster.source and tab == "opinions" %}
<div class="col-sm-12 alert-warning alert v-offset-above-2">
Expand Down
Loading