fix(search): Replaces smart quotes with double quotes in text queries #4855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the search functionality by replacing smart quotes ("“" and "”") with standard double quotes ("") in text queries. This ensures consistent handling of quotes
ERosendo
force-pushed
the
2790-fix-cleans-smart-quotes-from-text-query
branch
from
9925603 to
b3b13db
Compare
|
Guess we should have done this awhile ago...ah well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #2790 by improving the handling of quotes in text queries.
Key changes:
Replaces smart quotes (
“and”) with standard double quotes (") in text queriesUpdates the
check_unbalanced_quotesmethod to consider smart quotes when checking for unbalanced quotes in queries.