Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version pinned dependencies #685

Merged
merged 1 commit into from
May 23, 2023

Conversation

ttys0dev
Copy link
Contributor

Lets update these to their latest versions.

@mlissner
Copy link
Member

Did you read these release notes?

@ttys0dev
Copy link
Contributor Author

Looked to be bug fixes from what I could tell.

@ttys0dev
Copy link
Contributor Author

@mlissner does this look good to merge?

@mlissner
Copy link
Member

Hm, I'm fine upgrading most of these, but selenium tends to have a lot of broken pieces. We can give it a shot, but I suspect it'll break things.

@mlissner mlissner merged commit f6cc00f into freelawproject:main May 23, 2023
@ttys0dev ttys0dev deleted the update-deps branch May 23, 2023 22:43
@ttys0dev
Copy link
Contributor Author

We can give it a shot, but I suspect it'll break things.

I guess we need a new release here as well? Or are there some additional tests that we should run before hand?

@ttys0dev
Copy link
Contributor Author

Tests in courtlistener pass with updated selenium as well, just needed to make this tweak.

@mlissner
Copy link
Member

I think it should be fine. I think we use Selenium in three ways:

  • tests, here
  • tests in CL
  • to scrape, using a headless scraper defined in k8s as a pod (or perhaps a deployment)

So monkeying with it here should affect anything and I don't think it even needs a release.

@ttys0dev
Copy link
Contributor Author

I don't think it even needs a release.

Well if we don't have a release we have to use a git dependency in courtlistener like {git = "https://github.com/freelawproject/juriscraper.git", branch="main"} in order to use the newer selenium version.

@mlissner
Copy link
Member

I don't think so. CL sets a variable that means it uses a remote selenium driver instead of the one that's part of Juriscraper. Check out WEBDRIVER_CONN.

@ttys0dev
Copy link
Contributor Author

Check out WEBDRIVER_CONN.

Oh, that's for using a remote webdriver server I think, I'm just referring to updating the python client library version.

@mlissner
Copy link
Member

Hm, right, OK. @albertisfu could you do a release of Juriscraper when you get a sec, please?

@albertisfu
Copy link
Contributor

Sure, Juriscraper 2.4.8 release is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants