-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version pinned dependencies #685
Conversation
Did you read these release notes? |
Looked to be bug fixes from what I could tell. |
@mlissner does this look good to merge? |
Hm, I'm fine upgrading most of these, but selenium tends to have a lot of broken pieces. We can give it a shot, but I suspect it'll break things. |
I guess we need a new release here as well? Or are there some additional tests that we should run before hand? |
Tests in courtlistener pass with updated selenium as well, just needed to make this tweak. |
I think it should be fine. I think we use Selenium in three ways:
So monkeying with it here should affect anything and I don't think it even needs a release. |
Well if we don't have a release we have to use a git dependency in courtlistener like |
I don't think so. CL sets a variable that means it uses a remote selenium driver instead of the one that's part of Juriscraper. Check out |
Oh, that's for using a remote webdriver server I think, I'm just referring to updating the python client library version. |
Hm, right, OK. @albertisfu could you do a release of Juriscraper when you get a sec, please? |
Sure, |
Lets update these to their latest versions.