site ci: obtain site-version from latest tag #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required in the build-meta stage for determining the site-version. Signed-off-by: David Bauer <[email protected]> (cherry picked from commit 984f6d1)
Site-version had to be set in the past manually, even when tagging a release. As this is not done every time, just parse it from the latest tag on the history relative from the current commit. This ensures the site- and firmware-version are always determined from git tags when built from the CI. Signed-off-by: David Bauer <[email protected]> (cherry picked from commit ccf6015)
Retrieve the git tag relative to the directory the Makefile invokes the
git command. Previously, the directory git was working in was the one of
the root Makefile. When invoked from Gluon directly without using the CI
tooling, the tag retrieved would be obtained from the Gluon tree, not
the site tree.
Fixes: d8b10353b6c8 ("site ci: retrieve tags from directory of Makefile")
Signed-off-by: David Bauer <[email protected]>
(cherry picked from commit e5abde5)
blocktrron
force-pushed
the
v2023.2.x-ci-site-version
branch
from
763c1b7
to
417b50c
Compare
|
Blocked by #78 |
If the action is run in a fork, the versioning might be off as tags are most likely not to be updated in the fork. Fix this by fetching the tags from the upstream repo in case the action is run in the context of a fork. Signed-off-by: David Bauer <[email protected]> (cherry picked from commit ee13289) Signed-off-by: Tom Herbers <[email protected]>
Change the system timezone in the build-meta step to Europe/Berlin. This ensures the date of a testing firmware is determined for the correct timezone Freifunk Darmstadt is located in. Signed-off-by: David Bauer <[email protected]> Co-authored-by: Tom Herbers <[email protected]> (cherry picked from commit 3a97fcb) Signed-off-by: Tom Herbers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Site-version had to be set in the past manually, even when tagging a
release. As this is not done every time, just parse it from the latest
tag on the history relative from the current commit.
This ensures the site- and firmware-version are always determined from
git tags when built from the CI.
Signed-off-by: David Bauer [email protected]