Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion-script: do not convert symlinks #15

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

grische
Copy link
Collaborator

@grische grische commented Nov 19, 2023

Use symlink when original file was a symlink. This simplifies the script a lot and reduces the time for conversion by around 50%.

Before

real    3m51.010s
user    2m50.212s
sys     0m26.615s

After

real    2m12.928s
user    1m54.525s
sys     0m15.349s

@grische grische marked this pull request as ready for review November 19, 2023 19:24
@grische grische force-pushed the improve-symlink-conversion branch from 2621706 to b70ed74 Compare November 19, 2023 22:34
@grische
Copy link
Collaborator Author

grische commented Nov 19, 2023

@maurerle rebased on top of current main. This should work now

Use symlink when original file was a symlink. This simplifies the script a
lot and reduces the time for conversion by around 50%.
@grische grische force-pushed the improve-symlink-conversion branch from b70ed74 to e6fbb43 Compare November 19, 2023 22:43
@grische
Copy link
Collaborator Author

grische commented Nov 19, 2023

@maurerle yet another rebase on main

@maurerle maurerle merged commit ff4d1f5 into freifunk:main Nov 19, 2023
1 check passed
@grische grische deleted the improve-symlink-conversion branch November 19, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants