Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Linux wheels in GitHub CI #60

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

jeanas
Copy link
Member

@jeanas jeanas commented Aug 10, 2023

Apart from the usual benefit of CI for testing proposed changes, this will eventually make installing python-poppler-qt5 much easier. Currently, installing from PyPI compiles from source, which results in a bad user experience since lots of tools and a somewhat delicate setup are needed. The added CI job builds precompiled packages ("wheels") that can be uploaded to PyPI and should be compatible with current Linux distributions. The eventual goal is to improve this to build macOS and Windows wheels too.

Relates to #42

@jeanas jeanas requested a review from fedelibre August 10, 2023 02:14
@jeanas
Copy link
Member Author

jeanas commented Aug 10, 2023

This is quite black art and I haven't tested the wheels on a wide variety of systems... but they seem to work in a smoke test (using demo/demo.py) on both Fedora 38 and Ubuntu 22.04.

@jeanas
Copy link
Member Author

jeanas commented Aug 10, 2023

Another limitation I forgot to mention is that the wheels are only for Python 3.11.

Copy link
Member

@fedelibre fedelibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so glad you finally made it! (No matter the current limitations...)

Will you add a PyPI upload job to the GitHub workflow file? I think Wilbert gave you the access to PyPI, right?

pyproject.toml Outdated Show resolved Hide resolved
@jeanas
Copy link
Member Author

jeanas commented Aug 13, 2023

Will you add a PyPI upload job to the GitHub workflow file? I think Wilbert gave you the access to PyPI, right?

No, I don't have access to Frescobaldi-related projects on PyPI currently, only @wbsoft has.

Apart from the usual benefit of CI for testing proposed changes, this
will eventually make installing python-poppler-qt5 much
easier. Currently, installing from PyPI compiles from source, which
results in a bad user experience since lots of tools and a somewhat
delicate setup are needed. The added CI job builds precompiled packages
("wheels") that can be uploaded to PyPI and should be compatible with
current Linux distributions. The eventual goal is to improve this to
build macOS and Windows wheels too.

Relates to frescobaldi#42
@jeanas
Copy link
Member Author

jeanas commented Oct 15, 2023

@fedelibre PTAL.

@jeanas jeanas merged commit aba50a2 into frescobaldi:master Oct 16, 2023
1 check passed
@jeanas jeanas deleted the wheels branch October 16, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants