-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
경매 입찰 기능 구현 #163
Merged
Merged
경매 입찰 기능 구현 #163
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1697e42 - Browse repository at this point
Copy the full SHA 1697e42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 243b1e4 - Browse repository at this point
Copy the full SHA 243b1e4View commit details -
feat: #162 - Auction 엔티티에 낙관적 락 적용
- 최종 낙찰 금액에 해당하는 minBid -> finalBid로 직관적으로 수정
Configuration menu - View commit details
-
Copy full SHA for bedd5fe - Browse repository at this point
Copy the full SHA bedd5feView commit details -
- 입찰 요청 시 방어 로직 추가 - 요청한 입찰가는 이전 입찰가보다 높아야함 - 경매를 올린 사용자는 입찰이 불가능 - 경매가 시작하기 전 또는 후에는 입찰이 불가능 - 여러 사용자가 동시에 입찰을 시도할 경우 낙관적 락 OPTIMISTIC 옵션을 적용 - READ level에서 lock을 적용하여 잘못된 값을 조회하지 않도록 적용 - 낙관적 락 적용으로 인해 Exception이 발생할 경우 Retry 적용 - BackOff를 적용하여 1초 delay를 시작으로 max 5초까지 delay를 적용 - 최대 3번 retry 적용
Configuration menu - View commit details
-
Copy full SHA for 4e616a1 - Browse repository at this point
Copy the full SHA 4e616a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8df6c0 - Browse repository at this point
Copy the full SHA d8df6c0View commit details -
- AuctionRequest의 finalBid -> minimumBid 수정 - AuctionApi의 requestBidding -> placeBidding 수정
Configuration menu - View commit details
-
Copy full SHA for db2fd40 - Browse repository at this point
Copy the full SHA db2fd40View commit details -
feat: #162 - 입찰 기능의 비지니스 로직 수정
- 입찰 시간에 대한 방어 로직 조건이 잘못되어 수정 - 방어 로직을 따로 메소드 분리
Configuration menu - View commit details
-
Copy full SHA for f18ca57 - Browse repository at this point
Copy the full SHA f18ca57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 447d887 - Browse repository at this point
Copy the full SHA 447d887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17e1e61 - Browse repository at this point
Copy the full SHA 17e1e61View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.