-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
상품 수령 후 알림 #181
Merged
JadeKim042386
merged 7 commits into
develop
from
feature/#180-complete-delivery-auction
Jun 18, 2024
Merged
상품 수령 후 알림 #181
JadeKim042386
merged 7 commits into
develop
from
feature/#180-complete-delivery-auction
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 레포지토리에 auctionId로 존재하는지 확인하는 쿼리 메소드 추가
- Consumer에 추가한 큐를 등록
- 경매 리뷰 작성 요청을 받고 처리하는 비지니스 로직 구현 - 이미 리뷰를 작성했었는지 확인하는 방어 로직을 추가 - 리뷰를 DB에 저장하고 판매자에게 리뷰 작성 알림을 전송
src/main/java/freshtrash/freshtrashbackend/config/rabbitmq/BindingConfig.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/config/rabbitmq/QueueConfig.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/config/rabbitmq/QueueType.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/consumer/DeadLetterConsumer.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/consumer/ProductAlarmConsumer.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/controller/AuctionReviewApi.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/dto/constants/AlarmMessage.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/dto/request/AuctionAlarmPayload.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/dto/request/ReviewRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/dto/response/ReviewResponse.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/repository/AuctionReviewRepository.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/service/AuctionReviewService.java
Show resolved
Hide resolved
src/main/java/freshtrash/freshtrashbackend/service/producer/AuctionPublisher.java
Show resolved
Hide resolved
- 리뷰 작성 API, 비지니스 로직의 단위 테스트 코드 작성
- @max를 사용하여 rating 값을 최대 5가 입력될 수 있도록 validation 적용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍️ 이 PR을 통해 해결하려는 문제
구매자가 낙찰된 상품을 결제하고 판매자로부터 수령도 완료했을 경우 구매자는 상품을 정상적으로 수령했다는 의미로 리뷰를 작성해야합니다.
✨ 이 PR에서 핵심적으로 변경된 사항
AuctionReview 엔티티와 레포지토리 추가
리뷰관련 메시지를 전달받는 큐 추가
경매 리뷰 작성 API 구현
단위 테스트 코드 작성
🔖 핵심 변경 사항 외에 추가적으로 변경된 부분
📌 PR 진행 시 이러한 점들을 참고해 주세요
Issue Tags